Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrectly inserting role to YAML #29

Merged
merged 3 commits into from
May 13, 2020

Conversation

intagaming
Copy link
Contributor

Fixes #28

@intagaming
Copy link
Contributor Author

Sorry for that double commit... For some reason "targetMember", although not plural, is required to be an array. I didn't figure out the inner meaning and intention yet, but it also fixes a problem when the /info Form is not working with the Member & Role options.

@suerion
Copy link

suerion commented May 12, 2020

So, Roles are already Fixed, Branch is okey ;) i had tried it again with dev Tools, he has 1 File not saved.

Next Problem with Already given Players, this thing is already in HRK Migrator

[06:44:44] [Server thread/CRITICAL]: ErrorException: "Invalid argument supplied for foreach()" (EXCEPTION) in "plugins/HRKMigrator_dev-3.phar/src/CortexPE/HRKMigrator/Main" at line 165
[06:44:44] [Server thread/DEBUG]: #0 plugins/HRKMigrator_dev-3.phar/src/CortexPE/HRKMigrator/Main(165): pocketmine\utils\Utils::errorExceptionHandler(integer 2, string[39] Invalid argument supplied for foreach(), string[120] phar:///home/minecraft/multicraft/servers/PE/pocketmine/plugins/HRKMigrator_dev-, integer 165, array[18])
[06:44:44] [Server thread/DEBUG]: #1 plugins/HRKMigrator_dev-3.phar/src/CortexPE/HRKMigrator/Main(81): CortexPE\HRKMigrator\Main->doMigration()
[06:44:44] [Server thread/DEBUG]: #2 src/pocketmine/scheduler/ClosureTask(61): CortexPE\HRKMigrator\Main->CortexPE\HRKMigrator{closure}(integer 1)
[06:44:44] [Server thread/DEBUG]: #3 src/pocketmine/scheduler/TaskHandler(134): pocketmine\scheduler\ClosureTask->onRun(integer 1)
[06:44:44] [Server thread/DEBUG]: #4 src/pocketmine/scheduler/TaskScheduler(176): pocketmine\scheduler\TaskHandler->run(integer 1)
[06:44:44] [Server thread/DEBUG]: #5 src/pocketmine/plugin/PluginManager(643): pocketmine\scheduler\TaskScheduler->mainThreadHeartbeat(integer 1)
[06:44:44] [Server thread/DEBUG]: #6 src/pocketmine/Server(2380): pocketmine\plugin\PluginManager->tickSchedulers(integer 1)
[06:44:44] [Server thread/DEBUG]: #7 src/pocketmine/Server(2143): pocketmine\Server->tick()
[06:44:44] [Server thread/DEBUG]: #8 src/pocketmine/Server(1990): pocketmine\Server->tickProcessor()
[06:44:44] [Server thread/DEBUG]: #9 src/pocketmine/Server(1584): pocketmine\Server->start()
[06:44:44] [Server thread/DEBUG]: #10 src/pocketmine/PocketMine(273): pocketmine\Server->__construct(object BaseClassLoader, object pocketmine\utils\MainLogger, string[49] /home/minecraft/multicraft/servers/PE/pocketmine/, string[57] /home/minecraft/multicraft/servers/PE/pocketmine/plugins/)
[06:44:44] [Server thread/DEBUG]: #11 src/pocketmine/PocketMine(296): pocketmine\server()
[06:44:44] [Server thread/DEBUG]: #12 (11): require(string[104] phar:///home/minecraft/multicraft/servers/PE/pocketmine/PocketMine-MP.phar/src/p)

@intagaming

Copy link
Owner

@CortexPE CortexPE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes a lot of issues that I haven't encountered myself before, thank you for your contribution.

@CortexPE CortexPE merged commit c515f8d into CortexPE:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server Crash while Migration
3 participants