-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.7 Release Candidate One. #409
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a server/client architecture, the client can loose its connectivity. In this configuration, if the socket is not used, it will remains opened unti the server try to use it. In some cases, there is nothing to send to the client. The server should be able to send KEEP-ALIVE packets to detect unreachable clients. This patch adds some settings to configure this keep alive mechanism. Issue: #324
When installing Catch2 through CMake or pkg-config, the header file is in /usr/include/catch2 or the /usr/local equivalent, see the release notes: https://github.com/catchorg/Catch2/releases/tag/v2.3.0 Fix the include paths accordingly.
This automatically enables or disables tests, depending on whether Catch is found on the system. It is still possible to force building tests or not: * `-DBUILD_TESTS=OFF` will disable tests even if Catch is found * `-DBUILD_TESTS=ON` will enable tests even if Catch is not found (mostly useful because it causes cmake to fail early)
Build and portability fixes for 4.7 release
Fix String::format use of va_list
settings: add keep-alive options
maggu2810
pushed a commit
to maggu2810/restbed
that referenced
this pull request
Mar 14, 2022
4.7 Release Candidate One.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.