Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.7 Release Candidate One. #409

Merged
merged 34 commits into from
Mar 1, 2020
Merged

4.7 Release Candidate One. #409

merged 34 commits into from
Mar 1, 2020

Conversation

ben-crowhurst
Copy link
Member

No description provided.

AmarOk1412 and others added 30 commits March 13, 2019 10:32
In a server/client architecture, the client can loose its connectivity.
In this configuration, if the socket is not used, it will remains opened
unti the server try to use it. In some cases, there is nothing to send to
the client. The server should be able to send KEEP-ALIVE packets to
detect unreachable clients. This patch adds some settings to configure
this keep alive mechanism.

Issue: #324
When installing Catch2 through CMake or pkg-config, the header file is in
/usr/include/catch2 or the /usr/local equivalent, see the release notes:

https://github.com/catchorg/Catch2/releases/tag/v2.3.0

Fix the include paths accordingly.
This automatically enables or disables tests, depending on whether Catch
is found on the system.

It is still possible to force building tests or not:

  * `-DBUILD_TESTS=OFF` will disable tests even if Catch is found
  * `-DBUILD_TESTS=ON` will enable tests even if Catch is not found (mostly useful because it causes cmake to fail early)
Build and portability fixes for 4.7 release
Fix String::format use of va_list
settings: add keep-alive options
@ben-crowhurst ben-crowhurst added this to the 4.7 milestone Mar 1, 2020
@ben-crowhurst ben-crowhurst self-assigned this Mar 1, 2020
@ben-crowhurst ben-crowhurst merged commit 03f1f23 into master Mar 1, 2020
@ben-crowhurst ben-crowhurst linked an issue Mar 1, 2020 that may be closed by this pull request
maggu2810 pushed a commit to maggu2810/restbed that referenced this pull request Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doesn't work in visual studio 2019
4 participants