S3 objects are now flagged when they may require cleanup #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new flag to s3 object entities to indicate when version clean up may be needed. When an object version is set as the latest (i.e. version added or removed) we now also set the "cleanup required" flag. The clean up flag is only meaningful on the latest version of an object.
The bucket reaper task now performs version clean up only for these flagged objects rather than all objects in a bucket. This task clears the clean up flag after processing an object, allowing progress to be made even when there are many objects to be checked.
It is generally the case that periodic clean up is not required, as clean up is performed when updates to an object are made. Having a flag allows for manual triggering of object version clean up (via database change) should it ever be necessary.