Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose CheckedMultiplyFractionError publicly #1608

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Expose CheckedMultiplyFractionError publicly #1608

merged 2 commits into from
Mar 2, 2023

Conversation

grod220
Copy link
Contributor

@grod220 grod220 commented Feb 8, 2023

Follow up from: #1566

Sadly, CheckedMultiplyFractionError is not re-exported in packages/std/src/lib.rs. This is important as it prevents consumers from doing

    #[error("{0}")]
    CheckedMultiplyFraction(#[from] CheckedMultiplyFractionError),

At the moment, to use Fraction math, users have to map the errors manually on every use 😢

@grod220 grod220 mentioned this pull request Feb 15, 2023
Merged
@webmaster128
Copy link
Member

Thank you!

@webmaster128 webmaster128 added this to the 1.2.2 milestone Mar 2, 2023
@webmaster128 webmaster128 merged commit ca9abca into CosmWasm:main Mar 2, 2023
@webmaster128
Copy link
Member

Published as part of 1.2.2 today

@grod220 grod220 deleted the expose-fraction-error branch March 8, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@grod220 @webmaster128