Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Checksum for CodeInfoResponse #1944

Merged
merged 15 commits into from
Nov 21, 2023
Merged

Use Checksum for CodeInfoResponse #1944

merged 15 commits into from
Nov 21, 2023

Conversation

chipshort
Copy link
Collaborator

closes #1835

@chipshort chipshort marked this pull request as ready for review November 16, 2023 09:19
webmaster128
webmaster128 reviewed Nov 16, 2023
View reviewed changes
packages/std/src/checksum.rs Outdated Show resolved Hide resolved
contracts/virus/src/contract.rs Outdated Show resolved Hide resolved
webmaster128
webmaster128 reviewed Nov 19, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One somewhat relevant comment improvement + CHANGELOG. Then 🚀

packages/go-gen/tests/cosmwasm_std__CodeInfoResponse.go Outdated Show resolved Hide resolved
webmaster128
webmaster128 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to mention the removal of cosmwasm_vm::Checksum. Other than that, very nice

CHANGELOG.md Show resolved Hide resolved
@chipshort chipshort merged commit ddcd300 into main Nov 21, 2023
20 of 27 checks passed
@chipshort chipshort deleted the 1835-checksum-type branch November 21, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change CodeInfoResponse::checksum from HexBinary to cosmwasm_std::Checksum
2 participants
@chipshort @webmaster128