Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test pairing_equality_works_for_empty_lhs #2142

Merged
merged 1 commit into from
May 21, 2024
Merged

Add test pairing_equality_works_for_empty_lhs #2142

merged 1 commit into from
May 21, 2024

Conversation

webmaster128
Copy link
Member

@webmaster128 webmaster128 commented May 10, 2024 •
edited
Loading

After removal of the emptyness check for the left-hand side, we can now test 1 == e(a, b)

@webmaster128 webmaster128 requested a review from aumetra May 10, 2024 20:32
@webmaster128
Copy link
Member Author

Looking at this after writing the tests, it might not be super useful to have this feature since a caller can just test a == identity || b == identity instead of performing the pairing. But yeah, the API can do this now so we can test it.

@aumetra aumetra merged commit add97a0 into bls12_381 May 21, 2024
30 checks passed
@aumetra aumetra deleted the pairing_equality_works_for_empty_lhs branch May 21, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aumetra aumetra Awaiting requested review from aumetra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webmaster128 @aumetra