-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ibc stargate to vm #716
Conversation
Rebasing #714 on top of this branch, so I can test it with real data. But I would like to merge these changes independent of the other contract |
@webmaster128 this should be good to merge, unless you have any change requests. I tested these calls in #714 |
#[cfg(feature = "stargate")] | ||
fn default_features() -> HashSet<String> { | ||
features_from_csv("staking,stargate") | ||
} | ||
|
||
#[cfg(not(feature = "stargate"))] | ||
fn default_features() -> HashSet<String> { | ||
features_from_csv("staking") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#[cfg(feature = "stargate")] | |
fn default_features() -> HashSet<String> { | |
features_from_csv("staking,stargate") | |
} | |
#[cfg(not(feature = "stargate"))] | |
fn default_features() -> HashSet<String> { | |
features_from_csv("staking") | |
} | |
fn default_features() -> HashSet<String> { | |
#[cfg(feature = "stargate")] | |
{ | |
features_from_csv("staking,stargate") | |
} | |
#[cfg(not(feature = "stargate"))] | |
{ | |
features_from_csv("staking") | |
} | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not very pretty but avoids any mismatch in the function signature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They will have the same compile-time checks, and same code.
If there is a mismatch it is only detected under one cfg option. (The CI will catch any compile-time issues)
I find the current version more readable
Addresses #692