Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update namespaces / constructors to accept &str #170

Closed
maurolacy opened this issue Dec 11, 2020 · 0 comments · Fixed by #173
Closed

Update namespaces / constructors to accept &str #170

maurolacy opened this issue Dec 11, 2020 · 0 comments · Fixed by #173
Assignees
@maurolacy
Projects
Contract development

Comments

@maurolacy
Copy link
Contributor

Update all the namespaces in all the constructors in storage-plus to accept &str.

We can still store &[u8] internally (maybe change that later), but at least the constructor is simpler.
As &str.as_bytes() is a const fn, we can do this in a const constructor.
@maurolacy maurolacy self-assigned this Dec 11, 2020
@maurolacy maurolacy mentioned this issue Dec 11, 2020
Merged
@maurolacy maurolacy mentioned this issue Dec 11, 2020
Merged
@ethanfrey ethanfrey moved this from To do to In progress in Contract development Dec 11, 2020
Contract development automation moved this from In progress to Done Dec 11, 2020
ethanfrey added a commit that referenced this issue Dec 11, 2020
@ethanfrey
Fixup after rebase on PR #170
7ed5908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maurolacy maurolacy

Labels
None yet
Projects
No open projects
Contract development
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace byte slices by string slices in names and constructors CosmWasm/cw-plus
1 participant
@maurolacy