Replace byte slices by string slices in names and constructors #173

maurolacy · 2020-12-11T20:56:10Z

Closes #170.

I focused in names & ctors. Possibly other things can be changed as well, in other PR / PRs:

key(), prefix()
to_length_prefixed()
nested_namespace_with_keys()
load(), update(), save(), may_load(), ...
Bound
...

ethanfrey

Very nice

packages/cw4/src/query.rs

contracts/cw721-base/src/state.rs

packages/storage-plus/src/item.rs

Replace byte slices by string slices in names and constructors

ee98e01

maurolacy requested a review from ethanfrey December 11, 2020 20:56

ethanfrey added this to In progress in Contract development via automation Dec 11, 2020

ethanfrey moved this from In progress to Review in progress in Contract development Dec 11, 2020

ethanfrey approved these changes Dec 11, 2020

View reviewed changes

packages/cw4/src/query.rs Show resolved Hide resolved

contracts/cw721-base/src/state.rs Show resolved Hide resolved

packages/storage-plus/src/item.rs Show resolved Hide resolved

Contract development automation moved this from Review in progress to Reviewer approved Dec 11, 2020

ethanfrey merged commit 940775a into master Dec 11, 2020

Contract development automation moved this from Reviewer approved to Done Dec 11, 2020

ethanfrey deleted the byte-slices-to-str branch December 11, 2020 21:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace byte slices by string slices in names and constructors #173

Replace byte slices by string slices in names and constructors #173

maurolacy commented Dec 11, 2020 •

edited

ethanfrey left a comment

Replace byte slices by string slices in names and constructors #173

Replace byte slices by string slices in names and constructors #173

Conversation

maurolacy commented Dec 11, 2020 • edited

ethanfrey left a comment

Choose a reason for hiding this comment

maurolacy commented Dec 11, 2020 •

edited