Fix min threshold and vote power bugs in cw3-fixed-multisig #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueco-jb
force-pushed
the
551-fix-cw3fixedmultisig-votingpower
branch
from
ad35043
to
897ac2d
Compare
ueco-jb
commented
Dec 21, 2021
maurolacy
reviewed
Dec 22, 2021
Merged
…m cw3-flex-multisig
ueco-jb
force-pushed
the
551-fix-cw3fixedmultisig-votingpower
branch
3 times, most recently
from
6964f10
to
f97bebb
Compare
…tisig instantiate message
ueco-jb
force-pushed
the
551-fix-cw3fixedmultisig-votingpower
branch
from
f97bebb
to
090ccdd
Compare
…g would import it from cw3-fixed-multisig
|
You can use the |
…plementations" This reverts commit bf72c54.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #551
Couple hundred lines are mostly move some stuff like
ProposalandBallotstructs fromflextofixed-multisigcontracts, following Mauro's comment.EDIT: Actually scratch that... It appears that I can't just import common implementation incw3-flex-multisigfromcw3-fixed-multisig, becausewasm-buildcomplains during flex compilation about duplicate of symbols forinstantiate,executeandqueryfunctions.So in the end, I just copied whole implementation into
fixedcontract and removed tests fromflex- bit controversial, but they are copied intofixed. But I get that duplicated tests are still tests, so I can bring them back anyway.<yoda's voice>Use the
libraryfeature you must.</yoda's voice>