Move Threshold and coexisting implementations into packages/utils #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueco-jb
force-pushed
the
jakub/move-threshold-impl-to-utils
branch
from
4e0abc4
to
45f3731
Compare
ueco-jb
force-pushed
the
jakub/move-threshold-impl-to-utils
branch
from
45f3731
to
745984c
Compare
ueco-jb
force-pushed
the
jakub/move-threshold-impl-to-utils
branch
from
745984c
to
d91d837
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since both fixed and flex multisig contracts should rely on same threshold mechanics, I decided to move them into common place.
This PR should be delivered before #588. It will simplify then part of refactoring and therefore review.