Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryptography documentation #26

Merged
merged 11 commits into from
Jun 5, 2024
Merged

Cryptography documentation #26

merged 11 commits into from
Jun 5, 2024

Conversation

aumetra
Copy link
Member

@aumetra aumetra commented May 22, 2024

No description provided.

Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cosmwasm-docs ✅ Ready (Inspect) Visit Preview 1 resolved Jun 5, 2024 11:48am

@aumetra aumetra marked this pull request as ready for review May 24, 2024 13:18
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Do we have a place where we can talk about hashing? I.e. how hashing is typically done (let's say for sha256 and keccak256) and that we do not add them as host function? Then we have something to point to when closing CosmWasm/cosmwasm#1697 and similar initiatives.

src/pages/core/standard-library/cryptography.mdx Outdated Show resolved Hide resolved
src/pages/core/standard-library/cryptography/bls12-381.mdx Outdated Show resolved Hide resolved
src/pages/core/standard-library/cryptography/k256.mdx Outdated Show resolved Hide resolved
aumetra and others added 3 commits May 26, 2024 20:54
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
@aumetra
Copy link
Member Author

aumetra commented May 26, 2024

Do we have a place where we can talk about hashing? I.e. how hashing is typically done (let's say for sha256 and keccak256) and that we do not add them as host function?

We can add that to the overview page of cryptography. Seems like it would fit there neatly

Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this, but I have one comment/suggestion (left it on vercel). Please consider it before merging (if you do not agree its fine, but just don't ignore please).

@aumetra
Copy link
Member Author

aumetra commented Jun 5, 2024

I really like this, but I have one comment/suggestion (left it on vercel). Please consider it before merging (if you do not agree its fine, but just don't ignore please)

I added the prices to the docs itself. I used the link as kind of a placeholder since I wasn't sure when we were doing the repricing, but we did that earlier than I thought, so adding them now works.

@aumetra aumetra merged commit 7cb2146 into main Jun 5, 2024
3 checks passed
@aumetra aumetra deleted the cryptography-docs branch June 5, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants