Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Generic cw1-whitelist example #404

Merged
merged 13 commits into from
Aug 7, 2024
Merged

Conversation

abefernan
Copy link
Collaborator

@abefernan abefernan commented Jul 29, 2024

Part of #399.

Makes generic the contracts cw1-whitelist and cw1-subkeys on the examples. The latter depends on the former.

@abefernan abefernan self-assigned this Jul 29, 2024
@abefernan abefernan changed the base branch from main to examples-generic-ifaces July 29, 2024 09:54
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.30%. Comparing base (0bf0a22) to head (f0be28b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
- Coverage   82.37%   82.30%   -0.08%     
==========================================
  Files          53       53              
  Lines        3126     3113      -13     
==========================================
- Hits         2575     2562      -13     
  Misses        551      551              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abefernan abefernan marked this pull request as ready for review July 29, 2024 11:47
@abefernan abefernan force-pushed the examples-generic-ifaces branch 4 times, most recently from 7b4a585 to 4e0bafd Compare August 6, 2024 12:44
Base automatically changed from examples-generic-ifaces to main August 6, 2024 13:08
@abefernan abefernan force-pushed the examples-generic-cw1-whitelist branch from 0007a19 to 23129af Compare August 6, 2024 16:02
Copy link
Contributor

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@abefernan abefernan requested a review from jawoznia August 7, 2024 10:18
Copy link
Collaborator

@jawoznia jawoznia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@jawoznia jawoznia changed the title Generic cw1-whitelist example test: Generic cw1-whitelist example Aug 7, 2024
@jawoznia jawoznia merged commit 4c5a678 into main Aug 7, 2024
8 of 9 checks passed
@jawoznia jawoznia deleted the examples-generic-cw1-whitelist branch August 7, 2024 11:29
@github-actions github-actions bot mentioned this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants