close 815: upgrade to go 1.18 #866
Conversation
There was a problem hiding this comment.
Thanks for the PR. You are bleeding edge as always and I appreciate your energy and effort!
When we discussed this internally, the plan was to be a bit more conservative and follow the sdk roadmap on this.
The sdk v0.46.x and v0.45.x are still on Go 1.17.
IMHO this upgrade needs more time to settle but please comment on #815 if you have any requirements or see other chains upgrading to Go 1.18. This will help to get more confidence.
Other than this, your PR looks good. Just update the circle-ci image and Readme.
|
We have been running stargaze with go 1.18 without issues so far for a month probalby, we have not introduced any of the new features (generics) to the codebase tho. |
|
Given (whatever this is) could we consider moving to plain github actions? |
|
The new circleCI image is unfortunately not a drop in replacement. I have opened #872 and will 👀 when I get a chance |
|
Kinda my point about migrating to actions. Also, if we use actions, the whole repo becomes more easily forkable. |
|
got it :) |
|
@alpe what is the status here? I was happy not to merge before v0.27.0 (there was plenty in there already), but what about merging this now, to include in v0.28.0. Cosmos-sdk v0.46.0-rc1 us on Go 1.18 and Stargaze's experience is also positive (as they use CosmWasm and the whole stack) |
| @@ -1,6 +1,9 @@ | |||
| # Changelog | |||
|
|
|||
| ## [Unreleased](https://github.com/CosmWasm/wasmd/tree/HEAD) | |||
| - Upgrade go to v1.18 [\#866]https://github.com/CosmWasm/wasmd/pull/866/) ([faddat](https://github.com/faddat)) | |||
| @@ -13,7 +13,7 @@ This code was forked from the `cosmos/gaia` repository as a basis and then we ad | |||
| many gaia-specific files. However, the `wasmd` binary should function just like `gaiad` except for the | |||
| addition of the `x/wasm` module. | |||
|
|
|||
| **Note**: Requires [Go 1.17+](https://golang.org/dl/) | |||
| **Note**: Requires [Go 1.18+](https://golang.org/dl/) | |||
There was a problem hiding this comment.
👍 very good to have the doc up to date!
| @@ -8,7 +8,7 @@ protoc_gen_gocosmos() { | |||
| return 1 | |||
| fi | |||
|
|
|||
| go get github.com/regen-network/cosmos-proto/protoc-gen-gocosmos@latest 2>/dev/null | |||
| go install github.com/regen-network/cosmos-proto/protoc-gen-gocosmos@latest 2>/dev/null | |||
There was a problem hiding this comment.
This is not working with the docker image (tendermintdev/sdk-proto-gen) that we use. Can you revert this change/ test with make proto-gen ?
* Revert protocgen changes from #866 * Go mod tidy * Bump proto-gen image one version
* close 815: upgrade to go 1.18 * Update CHANGELOG.md * updater ci and docker to go 1.18 * update image per: https://discuss.circleci.com/t/legacy-convenience-image-deprecation/41034 * Update config.yml * go get -> go install, except dockerfile for protos
* Revert protocgen changes from CosmWasm#866 * Go mod tidy * Bump proto-gen image one version
This PR upgrades go to version 1.18
closes: