Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISS197: enable checking/reprojection of raster tile bounds vs. vector source CRS #203

Merged
merged 5 commits into from
Jul 18, 2019

Conversation

nrweir
Copy link
Contributor

@nrweir nrweir commented Jul 17, 2019

Description

solaris.tile.vector_tile.VectorTiler didn't previously check if the tile bounding box CRS and the vector file's CRS were the same. Added an argument, tile_bounds_crs, that enables users to provide the crs if they're different, and transform as necessary.

Fixes #197

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected - these changes will not be merged until major releases!)

How Has This Been Tested?

Checklist:

  • My PR has a descriptive title
  • My code follows PEP8
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new errors
  • I have added tests that prove my fix is effective or that my feature works
  • My PR passes Travis CI tests
  • My PR does not reduce coverage in Codecov

If your PR does not fulfill all of the requirements in the checklist above, that's OK! Just prepend [WIP] to the PR title until they are all satisfied. If you need help, @-mention a maintainer and/or add the Status: Help Needed label.

@nrweir nrweir mentioned this pull request Jul 17, 2019
@codecov-io
Copy link

codecov-io commented Jul 18, 2019

Codecov Report

Merging #203 into dev will increase coverage by 36.28%.
The diff coverage is 76.92%.

Impacted file tree graph

@@             Coverage Diff             @@
##              dev     #203       +/-   ##
===========================================
+ Coverage   29.97%   66.25%   +36.28%     
===========================================
  Files          54       67       +13     
  Lines        4020     4561      +541     
===========================================
+ Hits         1205     3022     +1817     
+ Misses       2815     1539     -1276
Impacted Files Coverage Δ
solaris/tile/vector_tile.py 78.12% <76.92%> (+62.03%) ⬆️
tests/test_cli/test_cli.py 93.33% <0%> (ø)
tests/test_nets/test_transform.py 100% <0%> (ø)
tests/test_eval/iou_test.py 100% <0%> (ø)
tests/test_nets/test_optimizers.py 100% <0%> (ø)
tests/test_eval/evaluator_test.py 100% <0%> (ø)
tests/test_eval/off_nadir_dataset_test.py 100% <0%> (ø)
tests/test_nets/test_datagen.py 100% <0%> (ø)
tests/test_nets/test_metrics.py 100% <0%> (ø)
tests/test_eval/pixel_test.py 100% <0%> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4d055b...5629eea. Read the comment docs.

@nrweir nrweir merged commit aff07c7 into dev Jul 18, 2019
@nrweir nrweir deleted the iss197_projection branch July 18, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants