Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokenFactory (v12) #368

Merged
merged 8 commits into from
Nov 18, 2022
Merged

TokenFactory (v12) #368

merged 8 commits into from
Nov 18, 2022

Conversation

Reecepbcups
Copy link
Contributor

@Reecepbcups Reecepbcups commented Nov 14, 2022

Close #334

  • adds in tokenfactory
  • adds v12 upgrade handler for tokenfactory with the new format

@Reecepbcups
Copy link
Contributor Author

Reecepbcups commented Nov 14, 2022

@faddat Do we want to merge this in now since it also has the v12 upgrade handler?

@faddat
Copy link
Contributor

faddat commented Nov 14, 2022

Yes

faddat
faddat previously approved these changes Nov 14, 2022
app/upgrades/v12/constants.go Outdated Show resolved Hide resolved
app/upgrades/v12/constants.go Outdated Show resolved Hide resolved
app/upgrades/v12/upgrades.go Outdated Show resolved Hide resolved
Reecepbcups and others added 3 commits November 15, 2022 01:41
Co-authored-by: Udit Gulati <85029005+udit-gulati@users.noreply.github.com>
Co-authored-by: Udit Gulati <85029005+udit-gulati@users.noreply.github.com>
Co-authored-by: Udit Gulati <85029005+udit-gulati@users.noreply.github.com>
@Reecepbcups
Copy link
Contributor Author

Reecepbcups commented Nov 15, 2022

@the-frey / @vuong177 Do we want a denomination creation fee?

I set to 1 JUNO here but maybe we make it free to do so or like 0.01 juno just to prevent spam creation of denoms

@vuong177
Copy link
Member

I think we should set it to 1 JUNO or higher.

@the-frey
Copy link
Collaborator

Agree that main thing is to charge something to avoid spam. Given that JUNO current value is hovering around $2 would say it's not unreasonable to be higher, but suspect that the marginal effect between say 0.1JUNO and like 10JUNO is probably negligible in terms of effect

@Reecepbcups
Copy link
Contributor Author

@the-frey Currently someone could spam upload CW20s for free. Given the bank module has better queries I do feel there is less overhead overall for a chain.

Most developers will need at minimum 2 tokens most likely, one for messing around first & one for actual production. I feel keeping the barrier to entry really low to start is best course of action.

If we find lots of spam, we can gov prop to increase param as needed

@the-frey
Copy link
Collaborator

Yep, happy with 1JUNO as a nominal fee

faddat
faddat previously approved these changes Nov 18, 2022
Copy link
Contributor

@faddat faddat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The road to uni

@faddat faddat mentioned this pull request Nov 18, 2022
9 tasks
@faddat faddat requested review from catShaark, dimiandre and a team November 18, 2022 06:47
@faddat faddat merged commit f46ae79 into main Nov 18, 2022
@Reecepbcups Reecepbcups mentioned this pull request Feb 6, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Token Factory Convert Tools
5 participants