Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v47] FeeShare Params Migrate #705

Merged
merged 8 commits into from
Jun 11, 2023
Merged

[v47] FeeShare Params Migrate #705

merged 8 commits into from
Jun 11, 2023

Conversation

Reecepbcups
Copy link
Contributor

@Reecepbcups Reecepbcups commented Jun 5, 2023

Migrates FeeShare to SDK v47 (Gov v1) + Updates to v16 namespace with #692

(Removed test-sim for now as this breaks pre param upgrade. Will dive into after we get all modules convered)

Review stars at 0acfbd2

Files of importance:

  • proto/juno/feeshare/v1/tx.proto
  • x/feeshare/keeper/params.go
  • x/feeshare/migrations/v2/*.go
  • x/feeshare/types/params*.go

commit 95e4bed
Author: Reece Williams <reecepbcups@gmail.com>
Date:   Mon Jun 5 14:43:38 2023 -0500

    Bump viper & testify per depbot

commit 419dc73
Author: Reece Williams <reecepbcups@gmail.com>
Date:   Mon Jun 5 14:38:56 2023 -0500

    Bump wasmvm v1.2.4

commit 36463f2
Merge: ffa617f c22ed14
Author: Reece Williams <reecepbcups@gmail.com>
Date:   Mon Jun 5 14:34:13 2023 -0500

    Merge branch 'main' into reece/v47-cleanup

commit ffa617f
Author: Reece Williams <reecepbcups@gmail.com>
Date:   Thu May 25 13:36:27 2023 -0500

    Update devtools/Makefile (simtest likely still fails bc of params?)

commit 8f4d3a8
Author: Reece Williams <reecepbcups@gmail.com>
Date:   Thu May 25 12:12:32 2023 -0500

    gofmt

commit d7fdbf9
Author: Reece Williams <reecepbcups@gmail.com>
Date:   Thu May 25 11:53:39 2023 -0500

    Bump IBC & Wasmd

commit a3482f1
Author: Reece Williams <reecepbcups@gmail.com>
Date:   Thu May 25 11:53:32 2023 -0500

    NFT module to upgrade

commit 027d3f6
Author: Reece Williams <reecepbcups@gmail.com>
Date:   Wed May 24 17:36:42 2023 -0500

    Adds the NFT module (per monday review call)

commit dac5f37
Author: Reece Williams <reecepbcups@gmail.com>
Date:   Wed May 24 10:32:07 2023 -0500

    Fix ICTest CosmosContracts/juno/v16

commit 465dae5
Author: Reece Williams <reecepbcups@gmail.com>
Date:   Wed May 24 10:29:17 2023 -0500

    Rename namespace to v16 (breaks ICtest for now)

commit eb06194
Author: Reece Williams <reecepbcups@gmail.com>
Date:   Wed May 24 10:28:01 2023 -0500

    Change SDKv47 upgrade to be v16

commit 91550f4
Author: Reece Williams <reecepbcups@gmail.com>
Date:   Tue May 23 14:44:56 2023 -0500

    stargaze queries: Params & Pool (Jake request)

commit 6695ed6
Author: Reece Williams <reecepbcups@gmail.com>
Date:   Tue May 23 11:49:57 2023 -0500

    comments from v47 review (May 22nd)

commit 4791d7a
Author: Reece Williams <reecepbcups@gmail.com>
Date:   Tue May 23 11:49:29 2023 -0500

    CI: Fix sim test & build every push

commit 8308d1d
Author: Reece Williams <reecepbcups@gmail.com>
Date:   Tue May 23 11:47:36 2023 -0500

    Remove IBCFee from upgrade handler

commit ade8434
Author: Reece Williams <reecepbcups@gmail.com>
Date:   Tue May 23 11:47:18 2023 -0500

    [testnode.sh] Improve script variables

commit b4a1eb0
Author: Reece Williams <reecepbcups@gmail.com>
Date:   Tue May 23 11:46:47 2023 -0500

    feeshare: remove unused keepers (Thanks Dimi)
@Reecepbcups Reecepbcups marked this pull request as ready for review June 5, 2023 20:36
@faddat
Copy link
Contributor

faddat commented Jun 6, 2023

@Reecepbcups which do you want to merge first? this contains some changes that are identical to the #692 -- or are they compatible?

Never-mind just saw the comment about review.

@Reecepbcups Reecepbcups enabled auto-merge (squash) June 6, 2023 12:15
Copy link
Member

@dimiandre dimiandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Reecepbcups Reecepbcups merged commit 0901c98 into main Jun 11, 2023
@Reecepbcups Reecepbcups mentioned this pull request Jul 7, 2023
12 tasks
@joelsmith-2019 joelsmith-2019 deleted the reece/v47-migrate-feeshare branch February 2, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants