Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 Conversion #12

Closed
bheavner opened this issue Oct 25, 2016 · 5 comments
Closed

Python 3 Conversion #12

bheavner opened this issue Oct 25, 2016 · 5 comments
Assignees
Projects

Comments

@bheavner
Copy link

I've encountered a few typos with setup.py when running with python 3.5. When I tried this:python setup.py install --prefix=/local/tools/HINT-1.1.1 --rgt-data-path=/local/tools/HINT-1.1.1 --rgt-tool=hint

I got the following error:

  File "setup.py", line 132
    except (BadOptionError,AmbiguousOptionError), e:

which I corrected by changing line 132 to:

except (BadOptionError,AmbiguousOptionError) as e:

then I got the following error:

  File "setup.py", line 398
    default_file_permission = 0644
                                 ^
SyntaxError: invalid token

which I corrected by changing line 398 and 299 to:

default_file_permission = 0o644
default_path_permission = 0o755

(apparently python3 doesn't like numbers beginning with 0. Octal numbers start with 0o)

then, the setup works. But then I get some errors when I attempt to run rgt-hint... I'll get to those in another issue.

@bheavner
Copy link
Author

It looks like I've hit a block in my python3 efforts - ngslib, which contains BigWigFile and is imported in HINT/signalProcessing.py, appears to be a python 2.7 dependency...

@fabio-t fabio-t changed the title python3 issues with setup.py Support lacking for python 3 Nov 8, 2016
@fabio-t
Copy link
Member

fabio-t commented Nov 8, 2016

Hi @bheavner, sorry for the late reply. We currently only support python 2, and only on Linux. I'm closing #13 and #14 and renaming this issue so that you'll be notified when we get around to make the code python3-friendly.

@fabio-t fabio-t added the feature label Nov 8, 2016
@fabio-t fabio-t self-assigned this Nov 8, 2016
fabio-t added a commit that referenced this issue Aug 23, 2017
fabio-t added a commit that referenced this issue Aug 30, 2017
@fabio-t fabio-t added this to In Progress in RGT Nov 17, 2017
@fabio-t fabio-t added the maybe label Nov 20, 2017
@fabio-t
Copy link
Member

fabio-t commented Dec 7, 2017

Pull request #46 has provided the first piece of the Python 3 puzzle. Some more work required on HINT, plus extensive testing, and then onto verifying each library's compatibility.

@fabio-t fabio-t removed the maybe label Dec 7, 2017
@fabio-t fabio-t changed the title Support lacking for python 3 Python 3 Conversion Feb 7, 2019
@fabio-t
Copy link
Member

fabio-t commented Feb 7, 2019

This now has higher priority. We'll probably drop Python 2.7 support and completely move to Python 3.

@fabio-t
Copy link
Member

fabio-t commented Mar 4, 2020

Finished with version 0.13.0.

@fabio-t fabio-t closed this as completed Mar 4, 2020
RGT automation moved this from In Progress to Done Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
RGT
  
Done
Development

No branches or pull requests

2 participants