Skip to content

Commit

Permalink
Updates cot_string_truncate to fix #1389
Browse files Browse the repository at this point in the history 
* serial spaces char in HTML mode now treats as one symbol
* all symbols `pre` or `plaintext` tags counts as common (plaintext)
char
  • Loading branch information
@macik
macik committed Jan 13, 2015
1 parent c245ae4 commit 1c27cef
Showing 1 changed file with 68 additions and 37 deletions.
105 changes: 68 additions & 37 deletions system/functions.php
View file
Expand Up @@ -4245,7 +4245,7 @@ function cot_string_truncate($text, $length = 100, $considerhtml = true, $exact
if ($considerhtml)
{
// if the plain text is shorter than the maximum length, return the whole text
if (mb_strlen(preg_replace('/<.*?>/', '', $text)) <= $length)
if (!preg_match('/<\s*(pre|plaintext)/', $text) && mb_strlen(preg_replace('/<.*?>/', '', $text)) <= $length)
{
return $text;
}
Expand All @@ -4255,6 +4255,7 @@ function cot_string_truncate($text, $length = 100, $considerhtml = true, $exact
$total_length = 0;
$open_tags = array();
$truncate = '';
$plain_mode = false;

foreach ($lines as $line_matchings)
{
Expand All @@ -4265,60 +4266,90 @@ function cot_string_truncate($text, $length = 100, $considerhtml = true, $exact
if (preg_match('/^<(\s*.+?\/\s*|\s*(img|br|input|hr|area|base|basefont|col|frame|isindex|link|meta|param)(\s.+?)?)>$/is', $line_matchings[1]))
{
// do nothing
// if tag is a closing tag (f.e. </b>)
}
// if tag is a closing tag (f.e. </b>)
elseif (preg_match('/^<\s*\/([^\s]+?)\s*>$/s', $line_matchings[1], $tag_matchings))
{
// delete tag from $open_tags list
$pos = array_search($tag_matchings[1], $open_tags);
if ($pos !== false)
$tag = false;
if (strtolower($tag_matchings[1]) == $plain_mode)
{
unset($open_tags[$pos]);
$plain_mode = false;
}
else
{
// delete tag from $open_tags list
$pos = array_search($tag_matchings[1], $open_tags);
if ($pos !== false)
{
unset($open_tags[$pos]);
}
}
// if tag is an opening tag (f.e. <b>)
}
// if tag is an opening tag (f.e. <b>)
elseif (preg_match('/^<\s*([^\s>!]+).*?>$/s', $line_matchings[1], $tag_matchings))
{
$tag = strtolower($tag_matchings[1]);
$plain_tag = in_array($tag, array('pre','plaintext')) ? $tag : false;
// add tag to the beginning of $open_tags list
array_unshift($open_tags, mb_strtolower($tag_matchings[1]));
if (!$plain_mode && !$plain_tag) array_unshift($open_tags, mb_strtolower($tag));
}
// add html-tag to $truncate'd text
$truncate .= $line_matchings[1];
if (!$plain_mode) $truncate .= $line_matchings[1];
}

// calculate the length of the plain text part of the line; handle entities as one character
$content_length = mb_strlen(preg_replace('/&[0-9a-z]{2,8};|&#[0-9]{1,7};|&#x[0-9a-f]{1,6};/i', ' ', $line_matchings[2]));
if ($total_length+$content_length> $length)
// the number of characters which are left
$left = $length - $total_length;
if ($plain_mode || ($plain_tag && $tag))
{
// treats text as plain in <pre>, <plaintext> tags
$content = $plain_mode ? $line_matchings[0] : $line_matchings[2];
if (mb_strlen($content) <= $left)
{
$truncate .= $content;
$total_length += mb_strlen($content);
}
else
{
$truncate .= mb_substr($content, 0, $left);
$total_length += $left;
}
if ($plain_tag && !$plain_mode) $plain_mode = $plain_tag;
}
else
{
// the number of characters which are left
$left = $length - $total_length;
$entities_length = 0;
// search for html entities
if (preg_match_all('/&[0-9a-z]{2,8};|&#[0-9]{1,7};|&#x[0-9a-f]{1,6};/i', $line_matchings[2], $entities, PREG_OFFSET_CAPTURE))
// calculate the length of the plain text part of the line; handle entities as one character
$content_length = mb_strlen(preg_replace('/&[0-9a-z]{2,8};|&#[0-9]{1,7};|&#x[0-9a-f]{1,6};|[\r\n\s]{2,}/i', ' ', $line_matchings[2]));
if ($total_length+$content_length> $length)
{
// calculate the real length of all entities in the legal range
foreach ($entities[0] as $entity)
$entities_length = 0;
// search for html entities and spaces
if (preg_match_all('/&[0-9a-z]{2,8};|&#[0-9]{1,7};|&#x[0-9a-f]{1,6};|[\r\n\s]{2,}/i', $line_matchings[2], $entities, PREG_OFFSET_CAPTURE))
{
if ($entity[1]+1-$entities_length <= $left)
{
$left--;
$entities_length += mb_strlen($entity[0]);
}
else
// calculate the real length of all entities in the legal range
foreach ($entities[0] as $entity)
{
// no more characters left
break;
if ($entity[1]+1-$entities_length <= $left)
{
$left--;
$entities_length += mb_strlen($entity[0]);
}
else
{
// no more characters left
break;
}
}
}
$truncate .= mb_substr($line_matchings[2], 0, $left+$entities_length);
// maximum lenght is reached, so get off the loop
$truncated_by_space = preg_match('/[\r\n\s]/', mb_substr($line_matchings[2], $left+$entities_length, 1));
break;
}
else
{
$truncate .= $line_matchings[2];
$total_length += $content_length;
}
$truncate .= mb_substr($line_matchings[2], 0, $left+$entities_length);
// maximum lenght is reached, so get off the loop
break;
}
else
{
$truncate .= $line_matchings[2];
$total_length += $content_length;
}

// if the maximum length is reached, get off the loop
Expand All @@ -4340,9 +4371,9 @@ function cot_string_truncate($text, $length = 100, $considerhtml = true, $exact
}
}

if (!$exact)
if (!$exact && !$truncated_by_space && !$plain_mode)
{
// ...search the last occurance of a space...
// ...search the last occurence of a space...
if (mb_strrpos($truncate, ' ') > 0)
{
$pos1 = mb_strrpos($truncate, ' ');
Expand Down

0 comments on commit 1c27cef

Please sign in to comment.