Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

News - De-functionize #315

Closed
trustmaster opened this issue Jul 3, 2011 · 1 comment
Closed

News - De-functionize #315

trustmaster opened this issue Jul 3, 2011 · 1 comment
Assignees
@esclkm
Milestone
Genoa 0.0.6

Comments

@trustmaster
Copy link
Member

News was previously changed into a function but this should not be. This causes all the variables to be localized and will break sed_url for advanced users

As well as there is no need for it to be a function.
@ghost ghost assigned esclkm Jul 3, 2011
@trustmaster
Copy link
Member Author

sed_url() functionality restored by esclkm in r825, no need to defunctionize actually.

And there's need for it to be a function to provide multiple news feeds with just 1 plugin instead of dedicated plugin for each feed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@esclkm esclkm

Labels
None yet
Projects
None yet
Milestone
Genoa 0.0.6
Development

No branches or pull requests
2 participants
@trustmaster @esclkm