Modified OUP plugin to add NC license with a trailing slash #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…L which appears in some journal cases
|
Ignore this one. I've found a bunch of other variant statements which I'll add into a new pull request. Lots of variants on trailing slashes and use vs re-use and other things...aaaarrrrghhhh! |
|
Ah, during straightening the OUP tests I put in a few CC-NC cases. So make sure to pull the repo again first before branching again - will make your life / pull request a lot easier, since I modified the plugin too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases the URL in the license text contains the trailing slash for the CC NC licenses and in some cases it doesn't. This was failing so have added the license statement with the trailing slash. There may also be some cases for the CC BY licenses but haven't found them yet.
See: #73