This repository has been archived by the owner on Sep 25, 2021. It is now read-only.
Switch from Ruby Sass to node-sass #7303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby Sass is officially deprecated (https://sass-lang.com/ruby-sass). This commit switches the Sass implementation from Ruby Sass to node-sass (which is a wrapper around libsass). Ruby Sass used config.rb to configure some paths; as this is not supported by node-sass, I needed to change the import statements in the scss files back to explicit paths. Also updated the README file to reflect this (and added an additional section about testing while I was at it).
|
Thanks for the pull request! Before a real human comes by, please make sure your report has all the below criteria checked
Please make sure you also read contribution guide and followed all the steps. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby Sass is officially deprecated (https://sass-lang.com/ruby-sass). This commit switches the Sass implementation from Ruby Sass to node-sass (which is a wrapper around libsass).
Ruby Sass used config.rb to configure some paths; as this is not supported by node-sass, I needed to change the import statements in the scss files back to explicit paths.
Also updated the README file to reflect this (and added an additional section about testing while I was at it).
Description of what this fixes:
Removes the dependency on Compass and Ruby Sass, which are no longer supported.
Related issues:
n/a