Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend auth tweaks #4254

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Frontend auth tweaks #4254

wants to merge 3 commits into from

Conversation

aapeliv
Copy link
Member

@aapeliv aapeliv commented Apr 24, 2024

Closes #4106

Backend checklist

  • Formatted my code by running autoflake --exclude src/proto -r -i --remove-all-unused-imports src && isort . && black . in app/backend
  • Added tests for any new code or added a regression test if fixing a bug
  • All tests pass
  • Run the backend locally and it works
  • Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

Web frontend checklist

  • Formatted my code with make format
  • There are no warnings from make lint
  • There are no console warnings when running the app
  • Added any new components to storybook
  • Added tests where relevant
  • All tests pass
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

I think some clients might be including the dot in the link which causes issues with tokens.
@aapeliv aapeliv changed the base branch from develop to frontend/feature/remember-me April 24, 2024 15:16
Base automatically changed from frontend/feature/remember-me to develop April 24, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show both login and password at login form
1 participant