Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/script-for-retroactive-session-content-hashing #159

Conversation

isaacna
Copy link
Collaborator

@isaacna isaacna commented Jan 29, 2022

Link to Relevant Issue

This pull request resolves #158

Description of Changes

Added a script for adding the content hash for every session in a firestore instance.

Running this script would be:

add_content_hash_to_sessions --google_credentials_file {PATH_TO_CREDS_FILE}

Testing

Ran this on my personal firestore instance and tested the following:

  • All session content hashes are added
  • We properly log which sessions still don't have the content hashes

@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #159 (8b5cf08) into main (ef049ad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   94.54%   94.54%           
=======================================
  Files          50       50           
  Lines        2548     2548           
=======================================
  Hits         2409     2409           
  Misses        139      139           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef049ad...8b5cf08. Read the comment docs.

Copy link
Member

@evamaxfield evamaxfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense for the most part! I will try to come up with a deployment strategy for implementing in cookiecutter. I kind of want to make a GitHub action that runs this and any future changes we need to make.

"Action: Upgrade 3.0.3 - 3.0.4 -- click to run" if that makes sense?

cdp_backend/bin/add_content_hash_to_sessions.py Outdated Show resolved Hide resolved
@isaacna
Copy link
Collaborator Author

isaacna commented Jan 30, 2022

I kind of want to make a GitHub action that runs this and any future changes we need to make.

"Action: Upgrade 3.0.3 - 3.0.4 -- click to run" if that makes sense?

I'm good with this. Not sure actions supports this, but we could try to make this action appear conditionally on if the version is <= 3.0.3

@isaacna isaacna merged commit 6143a5f into CouncilDataProject:main Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants