Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/store-session-content-hash-in-session-db-model #158

Conversation

isaacna
Copy link
Collaborator

@isaacna isaacna commented Jan 28, 2022

Link to Relevant Issue

This pull request resolves first part of CouncilDataProject/cookiecutter-cdp-deployment#75

Description of Changes

Added session_content_hash to the db model and all relevant places in the event gather pipeline that are necessary to support that.

Will write a script later that retroactively does this for existing session db rows

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #158 (b79810e) into main (0a43a37) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     CouncilDataProject/cdp-backend#158   +/-   ##
=======================================
  Coverage   94.53%   94.54%           
=======================================
  Files          50       50           
  Lines        2544     2548    +4     
=======================================
+ Hits         2405     2409    +4     
  Misses        139      139           
Impacted Files Coverage Δ
...ckend/tests/pipeline/test_event_gather_pipeline.py 100.00% <ø> (ø)
cdp_backend/database/functions.py 91.21% <100.00%> (+0.04%) ⬆️
cdp_backend/database/models.py 100.00% <100.00%> (ø)
cdp_backend/pipeline/event_gather_pipeline.py 85.75% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a43a37...b79810e. Read the comment docs.

Copy link
Member

@evamaxfield evamaxfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@evamaxfield evamaxfield merged commit ef049ad into CouncilDataProject:main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants