-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New blockchain
tools
#418
New blockchain
tools
#418
Conversation
ACK, except: And what are we going to do if we want to switch to btcd and they don't support |
You might find this interesting. We merged jcmorgan's code into viacoin, I cant remember if we made any improvements, but anyway, insight is simply not reliable. We then wrote drivers for clearinghoused and clearblockd to query viacoind directly. Anyway, we never considered making an upstream PR simply because it involved using a nonstandard daemon. https://github.com/ClearingHouse/clearinghoused/blob/master/lib/blockchain/addrindex.py I am sure you can find the other references. The only part I am not sure of is there were claims by Greg Maxwell that |
yes, I think many other people will do the same request as we do.. maybe even someone will do a PR.. @btcdrak , thank you for the informations! It's, in fact, great to control completely the backend, but I'am optimistic about the fact that |
@JahPowerBit I wouldnt hold your breath for it being integrated into |
I have seen an address index requested a few times, so I would gladly accept a pull request to btcd that provides a flag to enable it. As I mentioned in the referenced issue, I like the idea and see the benefits of it. The only concern I have is that it needs to be an option that is disabled by default due to the rather largish amount of additional space it consumes which is not that useful for non-developers. Unfortunately, I know there is a list long enough right now that those of us at Conformal won't get to work on it in the short term. However, if there is anyone willing to tackle adding it in a pull request, I would certainly work with them to make it happen. |
@JahPowerBit, what about 2) and 3)? |
@adamkrellenstein, |
Conflicts: test/conftest.py
New `blockchain` tools
@JahPowerBit @btcdrak @adamkrellenstein: Orphans have, for obvious reasons, a Example: [{
"txid": "9be9d3e8d35c0df8b4e092b0643adbcee57de10449f1e965e8a2300d3dec01ce",
...
"blockhash": "00000000000000000b067f6c8d7e7c9ef40c6664859226a8c4157b17b5278dc6",
"confirmations": 0
}, {
"txid": "9be9d3e8d35c0df8b4e092b0643adbcee57de10449f1e965e8a2300d3dec01ce",
...
"blockhash": "00000000000000001a21e2f02faedbc960b4298f57809a20429f680d9d89710f",
"confirmations": 9969,
"time": 1411057105,
"blocktime": 1411057105
}] |
@dexX7, thank you very much for the information. I just did a PR to skip unconfirmed transactions. |
Goals of this PR:
search_raw_transaction()
. This make the integration of another services very easy.jmcorgan
's fork ORinsight
+bitcoind
Notes:
Insight needs to be updated with the last version that contains this commit: bitpay/insight-api@63db916
jmcorgan
don't return unconfirmed transactions. There is two solutions I think:searchrawtransactions
(https://github.com/CounterpartyXCP/counterpartyd/blob/new_blockchain/lib/blockchain/jmcorgan.py#L15) complete the result with filtered transactions from themempool
.listunspent
for addresses in the wallet (more simple but --unconfirmed will works only with addresses in the wallet).blockr
andsochain
from theblockchain
module. They return a lot of timeout error and I don't see any good reason to maintain this 2 providers here.