This repository has been archived by the owner on Sep 25, 2019. It is now read-only.
Auto-grading with keyword answers #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
| it 'should display the options' do | ||
| expect(page).to have_text("Grading: #{mission.title}") | ||
| expect(page).to have_selector('.auto-grading-keyword', count: 2) |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
dariusf
force-pushed
the
dariusf/keyword-auto-grading
branch
from
8bc9eff
to
ded7d99
Compare
| as_enum :auto_grading_type, none: 0, exact: 1, keyword: 2 | ||
|
|
dariusf
force-pushed
the
dariusf/keyword-auto-grading
branch
3 times, most recently
from
9c1c986
to
a4fa463
Compare
| it 'should display the options' do | ||
| expect(page).to have_text("Grading: #{mission.title}") | ||
| expect(page).to have_selector('.auto-grading-exact', count: 2) | ||
| expect(page).to have_selector('.auto-grading-keyword', count: 2) |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| @@ -317,6 +344,11 @@ | |||
| explanation 'Some explanation' | |||
| end | |||
|
|
|||
| factory :auto_grading_keyword_option, class: Assessment::AutoGradingKeywordOption do | |||
| keyword 'keyword1' | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
dariusf
force-pushed
the
dariusf/keyword-auto-grading
branch
from
a4fa463
to
9766668
Compare
| @@ -1,7 +1,7 @@ | |||
| <%= simple_form_for @grading, url: (@grading.persisted? ? | |||
| course_assessment_submission_grading_path(@course, @assessment, @submission, @grading) : | |||
| course_assessment_submission_gradings_path(@course, @assessment, @submission)), | |||
| html: { class: "form-horizontal" } do |f| %> | |||
| htm: { class: "form-horizontal" } do |f| %> | |||
It is made to be less than the current max grade and positive. The validations go both ways, triggering when the max grade is changed, and when any score is changed. The latter is done because the score fields are dynamically created.
A number of forms have buttons that add associations and are rendered as links, due to `link_to_add_association` being called with incorrect parameters.
dariusf
force-pushed
the
dariusf/keyword-auto-grading
branch
from
9766668
to
2b7c78d
Compare
allenwq
pushed a commit
that referenced
this pull request
Jul 7, 2015
Auto-grading with keyword answers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements feature 4 in Shuqun's feature requests. Depends on #427.