This repository has been archived by the owner on Sep 25, 2019. It is now read-only.
Fix auto-grading inconsistencies #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was possible for keywords to be highlighted, but not to count towards auto-grading score. This DRYs up relevant parts by making them use a common way of matching keywords.
Spacing and errant punctuation no longer affect equality. This allows a wider range of simlar answers to test as correct.
| @@ -4,9 +4,8 @@ module AssessmentHelper | |||
| def highlight_keywords(original, keywords) | |||
| highlighted = original.dup | |||
| keywords.each do |keyword| | |||
| highlighted.gsub!(Regexp.new("\\b#{keyword}\\b"), content_tag(:mark, '\0').html_safe) | |||
| highlighted.gsub!(keyword_regex(keyword), content_tag(:mark, '\0').html_safe) | |||
allenwq
pushed a commit
that referenced
this pull request
Jul 22, 2015
…istencies Fix auto-grading inconsistencies
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes inconsistencies with keyword grading (previously it was possible that a keyword was highlighted, but not counted into the suggested grade).
Also made exact auto-grading less strict, so more answers will test as correct.