This repository has been archived by the owner on Sep 25, 2019. It is now read-only.
Switched to HTTPS to avoid mixed content warning #438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would prefer using a protocol-relative URI. Edutech is by a separate team and we do not run it. Adding an async attribute would probably not change the behaviour for the html5 shim, even if the user-agent does not support the attribute. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that Firefox was issuing a mixed content warning on the edutech homepage (which seems to use Coursemology, though I'm not sure how the two codebases are related). I'm not actually sure where Google's JS API is used in Coursemology, but fixing the mixed content warning is simple enough.
As an aside: Using the
asyncattribute for MSIE < 9 is pretty pointless, because IE only started supportingasyncat v. 10+ - http://caniuse.com/#feat=script-async