This repository has been archived by the owner on Sep 25, 2019. It is now read-only.
Sample answers for keyword auto-grading #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
General questions now have a field for teachers to input a sample answer. This field is shown together with keyword options and is input with them as well. Also improved presentation of empty keyword options.
| @@ -895,6 +895,18 @@ $grayMediumLight: #eaeaea; | |||
| /*float: right;*/ | |||
| } | |||
|
|
|||
| .rounded-box { | |||
| position: relative; | |||
| padding: 10px 10px 10px; | |||
There was a problem hiding this comment.
Shorthand form for property padding should be written more concisely as 10px instead of 10px 10px 10px
dariusf
force-pushed
the
dariusf/keyword-sample-answers
branch
from
371d7e1
to
3fe5d10
Compare
| position: relative; | ||
|
|
||
| h4 { | ||
| color: #666; |
There was a problem hiding this comment.
Color literals like #666 should only be used in variable declarations; they should be referred to via variable everywhere else.
dariusf
force-pushed
the
dariusf/keyword-sample-answers
branch
from
3fe5d10
to
76d091d
Compare
| $popoverProxy.popover('hide'); | ||
| $('[data-association="auto_grading_keyword_option"]').click(); | ||
|
|
||
| var $keywordField = $('#auto-grading-keyword > :nth-last-child(2) input[id$="keyword"]'); |
dariusf
force-pushed
the
dariusf/keyword-sample-answers
branch
from
76d091d
to
4fd7d88
Compare
| @@ -895,6 +896,15 @@ $grayMediumLight: #eaeaea; | |||
| /*float: right;*/ | |||
| } | |||
|
|
|||
| .rounded-box { | |||
| border: 1px solid $sampleAnswerBorder; | |||
There was a problem hiding this comment.
Name of variable sampleAnswerBorder should be written in all lowercase letters with hyphens instead of underscores
Existing keywords are highlighted in the keyword display when switching to it and when adding a new keyword.
dariusf
force-pushed
the
dariusf/keyword-sample-answers
branch
from
4fd7d88
to
420e57c
Compare
allenwq
pushed a commit
that referenced
this pull request
Sep 15, 2015
Sample answers for keyword auto-grading
|
@dariusf Thanks ! BTW, you should push changes to your own repo :) |
|
Thanks, I will next time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows teachers to input sample answers when creating general questions. These will be shown on grading, and can also be used as an alternative way to input keywords.