-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index and create for survey #1917
Index and create for survey #1917
Conversation
load_and_authorize_resource :survey, through: :course, class: Course::Survey.name | ||
add_breadcrumb :index, :course_surveys_path | ||
|
||
def index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put empty method definitions on a single line.
} | ||
|
||
// Default start date to start of next day in current Time Zone | ||
const defaultStartAt = new Date(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering, is it beneficial to move some of these default form values into a separate file/helper so we can set the defaults in just 1 file?
e446483
to
a4b1bb3
Compare
|
floatingLabelText: PropTypes.string, | ||
value: PropTypes.instanceOf(Date), | ||
errorText: PropTypes.string, | ||
onBlur: PropTypes.func.isRequired, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is required, means we cannot use it without redux-form
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separated the wrapper and underlying component in the latest push
Maybe making |
LGTM ! |
a4b1bb3
to
10f1196
Compare
Yeah, it's starting to look like a good idea. Quite troublesome to keep doing |
@kxmbrian think this can be merged after the build error is fixed. Thanks for the date time input, should be really useful ! |
10f1196
to
733cebb
Compare
Set up the front end for surveys.