Run ProgrammingEvaluation in service #2308

fonglh · 2017-05-29T09:19:03Z

Evaluate packages directly in ProgrammingEvaluationService instead of waiting for an external evaluator.

This will save the polling time, but worker servers will need to have Docker installed.

DO NOT MERGE YET.
For initial feedback, some refactoring and additional tests will be necessary.

houndci-bot · 2017-05-30T02:57:19Z

lib/autoload/coursemology_docker_container.rb

+    end
+
+    stream.close
+    result


Inconsistent indentation detected.

houndci-bot · 2017-05-30T02:57:19Z

lib/autoload/coursemology_docker_container.rb

+      result[block.stream] << block.bytes
+    end
+
+    stream.close


Inconsistent indentation detected.

houndci-bot · 2017-05-30T02:57:19Z

lib/autoload/coursemology_docker_container.rb

+		result = [''.dup, ''.dup, ''.dup]
+    stream = StringIO.new(string)
+
+    while (block = parse_docker_stream_read_block(stream))


Inconsistent indentation detected.

houndci-bot · 2017-05-30T02:57:19Z

lib/autoload/coursemology_docker_container.rb

+  # @return [Array<(String, String, String)>] The stdin, stdout, and stderr output.
+  def parse_docker_stream(string)
+		result = [''.dup, ''.dup, ''.dup]
+    stream = StringIO.new(string)


Inconsistent indentation detected.

houndci-bot · 2017-05-30T02:57:19Z

lib/autoload/coursemology_docker_container.rb

+  # @param [String] string The input stream to parse.
+  # @return [Array<(String, String, String)>] The stdin, stdout, and stderr output.
+  def parse_docker_stream(string)
+		result = [''.dup, ''.dup, ''.dup]


Tab detected.
Use 2 (not 0) spaces for indentation.

houndci-bot · 2017-05-30T02:57:19Z

app/services/course/assessment/programming_evaluation_service.rb

+
+      zip_entry_stream = entry.get_input_stream
+      new_entry_name = prefix ? File.join(prefix, entry.name) : entry.name
+      tar_file.add_file(new_entry_name, 0664) do |tar_entry_stream|


Use 0o for octal literals.

houndci-bot · 2017-05-30T02:57:19Z

app/services/course/assessment/programming_evaluation_service.rb

+    tar_file_stream
+  end
+
+	# Copies every entry from the zip archive to the tar archive, adding the optional prefix to the


Tab detected.
Incorrect indentation detected (column 1 instead of 2).

houndci-bot · 2017-05-30T02:57:19Z

app/services/course/assessment/programming_evaluation_service.rb

+    end
+  end
+
+	# Converts the zip package into a tar package for the container.


Tab detected.
Incorrect indentation detected (column 1 instead of 2).

houndci-bot · 2017-05-30T02:57:19Z

app/services/course/assessment/programming_evaluation_service.rb

+  def copy_package(container)
+		tar = tar_package(@package)
+    container.archive_in_stream(HOME_PATH) do
+			tar.read(Excon.defaults[:chunk_size]).to_s


Tab detected.
Use 2 (not -1) spaces for indentation.

houndci-bot · 2017-05-30T02:57:19Z

app/services/course/assessment/programming_evaluation_service.rb

+  # @param [Docker::Container] container The container to copy the package into.
+  def copy_package(container)
+		tar = tar_package(@package)
+    container.archive_in_stream(HOME_PATH) do


Inconsistent indentation detected.

houndci-bot · 2017-05-30T03:31:25Z

app/services/course/assessment/programming_evaluation_service.rb

+    result
+  end
+
+	# Copies the contents of the package to the container.


Tab detected.
Incorrect indentation detected (column 1 instead of 2).

houndci-bot · 2017-05-30T03:31:25Z

app/services/course/assessment/programming_evaluation_service.rb

+    result.push("-m#{@evaluation.memory_limit * MEMORY_LIMIT_RATIO}") if @evaluation.memory_limit
+
+    result
+  end


end at 155, 2 is not aligned with def at 149, 1.

houndci-bot · 2017-05-30T03:31:25Z

app/services/course/assessment/programming_evaluation_service.rb

+  end
+
+	def container_arguments
+    result = []


Use 2 (not 3) spaces for indentation.

houndci-bot · 2017-05-30T03:31:25Z

app/services/course/assessment/programming_evaluation_service.rb

+    CoursemologyDockerContainer.create(image_identifier, argv: container_arguments)
+  end
+
+	def container_arguments


Tab detected.
Inconsistent indentation detected.

houndci-bot · 2017-05-30T03:31:25Z

app/services/course/assessment/programming_evaluation_service.rb

+
+  def create_container(image)
+		image_identifier = "coursemology/evaluator-image-#{image}"
+    CoursemologyDockerContainer.create(image_identifier, argv: container_arguments)


Inconsistent indentation detected.

houndci-bot · 2017-05-30T03:31:25Z

app/services/course/assessment/programming_evaluation_service.rb

@@ -123,4 +140,104 @@ def wait_for_evaluation(evaluation)

    raise Timeout::Error if wait_result.nil?
  end
+
+  def create_container(image)
+		image_identifier = "coursemology/evaluator-image-#{image}"


Tab detected.
Use 2 (not 0) spaces for indentation.

houndci-bot · 2017-05-30T03:31:25Z

app/services/course/assessment/programming_evaluation_service.rb

  ensure
-    evaluation.destroy! if evaluation
+    @evaluation.destroy! if @evaluation
+    container.delete if container


Use safe navigation (&.) instead of checking if an object exists before calling the method.

houndci-bot · 2017-05-30T03:31:25Z

app/services/course/assessment/programming_evaluation_service.rb

  ensure
-    evaluation.destroy! if evaluation
+    @evaluation.destroy! if @evaluation


Use safe navigation (&.) instead of checking if an object exists before calling the method.

houndci-bot · 2017-05-30T03:31:25Z

app/services/course/assessment/programming_evaluation_service.rb

@@ -5,6 +5,18 @@ class Course::Assessment::ProgrammingEvaluationService
  DEFAULT_TIMEOUT = Course::Assessment::ProgrammingEvaluation::TIMEOUT
  CPU_TIMEOUT = Course::Assessment::ProgrammingEvaluation::CPU_TIMEOUT

+	# The path to the Coursemology user home directory.
+  HOME_PATH = '/home/coursemology'.freeze


Freezing immutable objects is pointless.

houndci-bot · 2017-05-30T03:31:25Z

app/services/course/assessment/programming_evaluation_service.rb

@@ -5,6 +5,18 @@ class Course::Assessment::ProgrammingEvaluationService
  DEFAULT_TIMEOUT = Course::Assessment::ProgrammingEvaluation::TIMEOUT
  CPU_TIMEOUT = Course::Assessment::ProgrammingEvaluation::CPU_TIMEOUT

+	# The path to the Coursemology user home directory.


Tab detected.
Incorrect indentation detected (column 1 instead of 2).

houndci-bot · 2017-05-31T09:35:35Z

spec/support/stubs/course/assessment/stubbed_programming_evaluation_service.rb

-    thread.abort_on_exception = true
+  def evaluate_in_container
+    attributes = FactoryGirl.attributes_for(:course_assessment_programming_evaluation, :completed).
+      slice(:stdout, :stderr, :test_report, :exit_code)


Align slice with FactoryGirl.attributes_for(:course_assessment_programming_evaluation, :completed). on line 6.

houndci-bot · 2017-05-31T09:35:36Z

lib/autoload/coursemology_docker_container.rb

+  #
+  # @return [Array<(String, String, String, Integer)>] The stdout, stderr, test report and exit
+  #   code.
+  def get_evaluation_result


Do not prefix reader method names with get_.

houndci-bot · 2017-05-31T09:35:36Z

lib/autoload/coursemology_docker_container.rb

+    retry
+  end
+
+


Extra blank line detected.

houndci-bot · 2017-05-31T09:35:36Z

lib/autoload/coursemology_docker_container.rb

+# frozen_string_literal: true
+class CoursemologyDockerContainer < Docker::Container
+  # The path to the Coursemology user home directory.
+  HOME_PATH = '/home/coursemology'.freeze


Freezing immutable objects is pointless.

houndci-bot · 2017-05-31T09:35:36Z

lib/autoload/coursemology_docker_container.rb

@@ -0,0 +1,211 @@
+# frozen_string_literal: true
+class CoursemologyDockerContainer < Docker::Container


Class has too many lines. [118/100]

houndci-bot · 2017-05-31T09:42:51Z

lib/autoload/coursemology_docker_container.rb

@@ -0,0 +1,207 @@
+# frozen_string_literal: true
+class CoursemologyDockerContainer < Docker::Container


Class has too many lines. [116/100]

houndci-bot · 2017-06-01T03:31:13Z

spec/support/stubs/course/assessment/stubbed_programming_evaluation_service.rb

+  def evaluate_in_container
+    attributes = FactoryGirl.attributes_for(:course_assessment_programming_evaluation, :completed).
+                   slice(:stdout, :stderr, :test_report, :exit_code)
+    sleep(0.2)  # For timeout testing


Unnecessary spacing detected.

houndci-bot · 2017-06-01T03:31:13Z

spec/services/course/assessment/programming_evaluation_service_spec.rb

@@ -94,30 +94,10 @@
        expect do
          subject.execute(course, Coursemology::Polyglot::Language::Python::Python2Point7.instance,
                          64, 5.seconds, File.join(Rails.root, 'spec', 'fixtures', 'course',
-                                                   'programming_question_template.zip'), 0.seconds)
+                                                   'programming_question_template.zip'),
+                                                   0.1.seconds)


Align the parameters of a method call if they span more than one line.

houndci-bot · 2017-06-01T03:31:13Z

lib/autoload/coursemology_docker_container.rb

+      ActiveSupport::Notifications.instrument('create.docker.evaluator.coursemology',
+                                              image: image) do |payload|
+        options = { 'Image' => image }
+        options['Cmd'] = argv if argv && !argv.empty?


Use argv.present? instead of argv && !argv.empty?.

houndci-bot · 2017-06-01T03:31:13Z

lib/autoload/coursemology_docker_container.rb

+# frozen_string_literal: true
+class CoursemologyDockerContainer < Docker::Container
+  # The path to the Coursemology user home directory.
+  HOME_PATH = '/home/coursemology'.freeze


Do not freeze immutable objects, as freezing them has no effect.

houndci-bot · 2017-06-01T03:31:13Z

lib/autoload/coursemology_docker_container.rb

@@ -0,0 +1,210 @@
+# frozen_string_literal: true
+class CoursemologyDockerContainer < Docker::Container


Add an empty line after magic comments.
Class has too many lines. [118/100]

houndci-bot · 2017-06-01T03:31:14Z

spec/support/stubs/course/assessment/stubbed_programming_evaluation_service.rb

+  def evaluate_in_container
+    attributes = FactoryGirl.attributes_for(:course_assessment_programming_evaluation, :completed).
+                   slice(:stdout, :stderr, :test_report, :exit_code)
+    sleep(0.2)  # For timeout testing


Unnecessary spacing detected.

houndci-bot · 2017-06-01T03:31:14Z

spec/services/course/assessment/programming_evaluation_service_spec.rb

@@ -94,30 +94,10 @@
        expect do
          subject.execute(course, Coursemology::Polyglot::Language::Python::Python2Point7.instance,
                          64, 5.seconds, File.join(Rails.root, 'spec', 'fixtures', 'course',
-                                                   'programming_question_template.zip'), 0.seconds)
+                                                   'programming_question_template.zip'),
+                                                   0.1.seconds)


Align the parameters of a method call if they span more than one line.

houndci-bot · 2017-06-01T03:31:14Z

lib/autoload/coursemology_docker_container.rb

+      ActiveSupport::Notifications.instrument('create.docker.evaluator.coursemology',
+                                              image: image) do |payload|
+        options = { 'Image' => image }
+        options['Cmd'] = argv if argv && !argv.empty?


Use argv.present? instead of argv && !argv.empty?.

houndci-bot · 2017-06-01T03:31:14Z

lib/autoload/coursemology_docker_container.rb

+# frozen_string_literal: true
+class CoursemologyDockerContainer < Docker::Container
+  # The path to the Coursemology user home directory.
+  HOME_PATH = '/home/coursemology'.freeze


Do not freeze immutable objects, as freezing them has no effect.

houndci-bot · 2017-06-01T03:31:14Z

lib/autoload/coursemology_docker_container.rb

@@ -0,0 +1,210 @@
+# frozen_string_literal: true
+class CoursemologyDockerContainer < Docker::Container


Add an empty line after magic comments.
Class has too many lines. [118/100]

houndci-bot · 2017-06-01T06:40:38Z

spec/services/course/assessment/programming_evaluation_service_spec.rb

          subject.execute(course, Coursemology::Polyglot::Language::Python::Python2Point7.instance,
                          64, 5.seconds, File.join(Rails.root, 'spec', 'fixtures', 'course',
-                                                   'programming_question_template.zip'), 0.seconds)
+                                                   'programming_question_template.zip'),
+                                                    0.1.seconds)


Align the parameters of a method call if they span more than one line.

houndci-bot · 2017-06-01T06:45:56Z

lib/autoload/coursemology_docker_container.rb

+class CoursemologyDockerContainer < Docker::Container
+
+  # The path to the Coursemology user home directory.
+  HOME_PATH = '/home/coursemology'.freeze


Do not freeze immutable objects, as freezing them has no effect.

houndci-bot · 2017-06-01T06:45:57Z

lib/autoload/coursemology_docker_container.rb

@@ -0,0 +1,211 @@
+# frozen_string_literal: true
+class CoursemologyDockerContainer < Docker::Container
+


Extra empty line detected at class body beginning.

houndci-bot · 2017-06-01T06:50:19Z

lib/autoload/coursemology_docker_container.rb

@@ -0,0 +1,211 @@
+# frozen_string_literal: true
+
+class CoursemologyDockerContainer < Docker::Container


Class has too many lines. [118/100]

houndci-bot · 2017-06-01T06:50:19Z

lib/autoload/coursemology_docker_container.rb

@@ -0,0 +1,211 @@
+# frozen_string_literal: true
+
+class CoursemologyDockerContainer < Docker::Container


Class has too many lines. [118/100]

houndci-bot · 2017-06-01T06:50:19Z

lib/autoload/coursemology_docker_container.rb

@@ -0,0 +1,211 @@
+# frozen_string_literal: true
+
+class CoursemologyDockerContainer < Docker::Container


Class has too many lines. [118/100]

houndci-bot · 2017-06-01T09:29:57Z

spec/services/course/assessment/programming_evaluation_service_spec.rb

+      let(:time_limit) { nil }
+      let(:service_instance) do
+        subject.new(course, Coursemology::Polyglot::Language::Python::Python2Point7.instance,
+                    memory_limit, time_limit, File.join(Rails.root, 'spec', 'fixtures', 'course',


Please use Rails.root.join('path', 'to') instead.

houndci-bot · 2017-06-02T08:12:12Z

spec/services/course/assessment/programming_evaluation_service_spec.rb

-          new(course, Coursemology::Polyglot::Language::Python::Python2Point7.instance, 64,
-              5.seconds, File.join(Rails.root, 'spec', 'fixtures', 'course',
-                                   'programming_question_template.zip'), 5.seconds)
+    describe '#create_container' do


Block has too many lines. [26/25]

houndci-bot · 2017-06-02T08:12:12Z

spec/libraries/coursemology_docker_container_spec.rb

+    end
+  end
+
+  describe '#extract_test_report' do


Block has too many lines. [27/25]

houndci-bot · 2017-06-02T08:12:12Z

spec/libraries/coursemology_docker_container_spec.rb

+    after { subject.send(:delete) }
+
+    it 'does not expose raw Docker Attach Protocol in the output' do
+      stdout, stderr, _, _ = subject.send(:evaluation_result)


Do not use trailing _s in parallel assignment. Prefer stdout, stderr, = subject.send(:evaluation_result).

houndci-bot · 2017-06-02T08:12:12Z

spec/libraries/coursemology_docker_container_spec.rb

+    it 'returns the exit code of the container' do
+      expect(subject.wait).to eq(subject.exit_code)
+    end
+  end


end at 30, 2 is not aligned with describe '#wait' do at 11, 1.

This is outdated.

houndci-bot · 2017-06-02T08:12:12Z

spec/libraries/coursemology_docker_container_spec.rb

+  end
+  subject { CoursemologyDockerContainer.create(image) }
+
+	describe '#wait' do


Tab detected.
Inconsistent indentation detected.

houndci-bot · 2017-06-02T08:12:12Z

spec/libraries/coursemology_docker_container_spec.rb

+# frozen_string_literal: true
+require 'rails_helper'
+
+RSpec.describe CoursemologyDockerContainer do


Block has too many lines. [111/25]

houndci-bot · 2017-06-02T08:12:12Z

spec/libraries/coursemology_docker_container_spec.rb

@@ -0,0 +1,140 @@
+# frozen_string_literal: true
+require 'rails_helper'


Add an empty line after magic comments.

allenwq · 2017-06-07T03:12:40Z

lib/autoload/coursemology_docker_container.rb

+
+class CoursemologyDockerContainer < Docker::Container
+  # The path to the Coursemology user home directory.
+  HOME_PATH = '/home/coursemology'.freeze


So evaluator will assume that there's a coursemology user ?

Yes. This setup is from the docker file

Provides abstractions to work with Docker containers.

Previously, the ProgrammingEvaluationService created evaluations and waited for external evaluators to run the evaluation and update its state. To elimimate the polling time of these external evaluators, move actual evaluation using docker containers into the service so the worker can run it immediately. No longer create ProgrammingEvaluation objects. Use Ruby's timeout on the execute method instead of the old method of using the custom AR extension for the ProgrammingEvaluation object.

Return the expected array of values during testing instead of spinning up a Docker container for actual evaluation. Add a short sleep to facilitate timeout testing. Remove `wait_for_evaluation` stub. Fix ProgrammingEvaluationService specs. Use a non-zero timeout as Ruby timeout treats 0 as infinite. Remove create_evaluation tests.

Adapted from corresponding specs in evaluator-slave.

Adapted from corresponding specs in evaluator-slave. Specify use of Docker to Travis. Install nodejs 6 as VM based trusty uses an old incompatible version.

* The first component can be random depends on the order of the loading

fonglh added Blocked Needs Review labels May 29, 2017

fonglh force-pushed the fonglh/evaluate-in-worker branch from ddbecfb to a2901fb Compare May 30, 2017 02:57

houndci-bot reviewed May 30, 2017

View reviewed changes

fonglh force-pushed the fonglh/evaluate-in-worker branch from a2901fb to 0453437 Compare May 30, 2017 03:31

houndci-bot reviewed May 30, 2017

View reviewed changes

fonglh force-pushed the fonglh/evaluate-in-worker branch 3 times, most recently from 6d4b6c6 to bd4b649 Compare May 31, 2017 09:35

houndci-bot reviewed May 31, 2017

View reviewed changes

fonglh force-pushed the fonglh/evaluate-in-worker branch from bd4b649 to 867b11e Compare May 31, 2017 09:40

houndci-bot reviewed May 31, 2017

View reviewed changes

fonglh force-pushed the fonglh/evaluate-in-worker branch 3 times, most recently from 51edf0d to e6799dd Compare June 1, 2017 03:31

houndci-bot reviewed Jun 1, 2017

View reviewed changes

fonglh force-pushed the fonglh/evaluate-in-worker branch 2 times, most recently from 418aebb to 410f7da Compare June 1, 2017 06:40

houndci-bot reviewed Jun 1, 2017

View reviewed changes

fonglh force-pushed the fonglh/evaluate-in-worker branch from 410f7da to e73821a Compare June 1, 2017 06:45

houndci-bot reviewed Jun 1, 2017

View reviewed changes

fonglh force-pushed the fonglh/evaluate-in-worker branch from e73821a to dbde6f9 Compare June 1, 2017 06:50

houndci-bot reviewed Jun 1, 2017

View reviewed changes

fonglh force-pushed the fonglh/evaluate-in-worker branch from 65f2b5d to 0337c89 Compare June 2, 2017 08:11

houndci-bot reviewed Jun 2, 2017

View reviewed changes

fonglh force-pushed the fonglh/evaluate-in-worker branch from 0337c89 to db59a4c Compare June 2, 2017 17:07

allenwq reviewed Jun 7, 2017

View reviewed changes

allenwq closed this Jun 7, 2017

allenwq deleted the fonglh/evaluate-in-worker branch June 7, 2017 04:36

allenwq restored the fonglh/evaluate-in-worker branch June 7, 2017 04:36

allenwq removed the Needs Review label Jun 7, 2017

allenwq reopened this Jun 7, 2017

allenwq added the Needs Review label Jun 7, 2017

fonglh force-pushed the fonglh/evaluate-in-worker branch from bc734f8 to 2b176f6 Compare June 7, 2017 06:36

allenwq closed this Jun 28, 2017

allenwq deleted the fonglh/evaluate-in-worker branch June 28, 2017 07:15

allenwq restored the fonglh/evaluate-in-worker branch June 28, 2017 07:16

allenwq removed the Needs Review label Jun 28, 2017

allenwq reopened this Jun 28, 2017

allenwq added the Needs Review label Jun 28, 2017

fonglh and others added 6 commits June 28, 2017 17:45

Add Docker API gem.

09ef736

Provides abstractions to work with Docker containers.

Add specs for create_container in ProgrammingEvaluationService.

0c44d58

Adapted from corresponding specs in evaluator-slave.

Add specs for CoursemologyDockerContainer.

5989741

Adapted from corresponding specs in evaluator-slave. Specify use of Docker to Travis. Install nodejs 6 as VM based trusty uses an old incompatible version.

Only use the component that can be disabled to test

cd37f09

* The first component can be random depends on the order of the loading

fonglh force-pushed the fonglh/evaluate-in-worker branch from 2b176f6 to cd37f09 Compare June 28, 2017 09:46

fonglh removed the Blocked label Jun 29, 2017

allenwq merged commit 5cc01ab into Coursemology:master Jun 29, 2017

allenwq removed the Needs Review label Jun 29, 2017

fonglh deleted the fonglh/evaluate-in-worker branch July 5, 2017 07:45

This was referenced Jul 5, 2017

Investigate Evaluator performance #2122

Open

Remove Course::Assessment::ProgrammingEvaluation model #2345

Closed

Delete package after programming evaluation #2347

Closed

fonglh mentioned this pull request Oct 24, 2017

Redesign evaluator #2004

Open

jeremyyap mentioned this pull request Nov 14, 2017

Evaluator which is not system auto grader will kill postgres #970

Closed

		@@ -0,0 +1,211 @@
		# frozen_string_literal: true
		class CoursemologyDockerContainer < Docker::Container

		@@ -0,0 +1,207 @@
		# frozen_string_literal: true
		class CoursemologyDockerContainer < Docker::Container

		@@ -0,0 +1,210 @@
		# frozen_string_literal: true
		class CoursemologyDockerContainer < Docker::Container

		@@ -0,0 +1,140 @@
		# frozen_string_literal: true
		require 'rails_helper'

Run ProgrammingEvaluation in service #2308

Run ProgrammingEvaluation in service #2308

Conversation

fonglh commented May 29, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment