Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(image_uploader): catch error when medium.url not found when duplicating images #4162

Merged
merged 1 commit into from
Nov 9, 2021
Merged

fix(image_uploader): catch error when medium.url not found when duplicating images #4162

merged 1 commit into from
Nov 9, 2021

Conversation

ekowidianto
Copy link
Member

@ekowidianto ekowidianto commented Nov 9, 2021 •
edited

Temporary patch for the image duplication issue. Replace missing images with default image.

zhuhanming
zhuhanming approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@zhuhanming zhuhanming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, agreed that this should be a temporary patch, while we look for a proper fix (likely with the AWS side).

@zhuhanming zhuhanming merged commit 6e93984 into master Nov 9, 2021
@zhuhanming zhuhanming deleted the eko/add-standard-error-image-duplication branch November 9, 2021 11:06
@cysjonathan cysjonathan mentioned this pull request Nov 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhuhanming zhuhanming zhuhanming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ekowidianto @zhuhanming