Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG_SP] Worker doesn't stop at End of Course. #323

Closed
ph1go opened this issue Jan 2, 2022 · 16 comments
Closed

[BUG_SP] Worker doesn't stop at End of Course. #323

ph1go opened this issue Jan 2, 2022 · 16 comments
Assignees
@pvaiko
Labels
bug Something isn't working

Comments

@ph1go
Copy link

ph1go commented Jan 2, 2022 •
edited
Loading

It doesn't happen consistently so it's difficult to reproduce. It didn't matter this time but previously it happened with a cultivator driving into a seeded field with the implement down. You can see it still thinks it's following a path in the first screenshot and in second is where it stopped (and you can see the mulched grass behind).

Courseplay version
Version used: V7.0.0.11 and previous versions

Log
(right at the end)
log.txt

Map
Elmscreek

Vehicles/ implements involved
Nothing modded, I've seen it with the 6m TMC Cancela mulcher and the Kompaktomat 1570 cultivator.

fsScreen_2022_01_02_19_18_00
fsScreen_2022_01_02_19_18_07
@ph1go ph1go added the bug Something isn't working label Jan 2, 2022
@Tensuko
Copy link
Contributor

Tensuko commented Jan 2, 2022

One more Headland, maybe also skip rows ?

@Tensuko Tensuko added the waiting for user User answer needed label Jan 2, 2022
@ph1go
Copy link
Author

ph1go commented Jan 2, 2022

One more Headland, maybe also skip rows ?

Two headlands is fine for turning for the interior rows. It does everything perfectly in the field, it just carries on in a straight line for ~30m at the very end of the course. It's like it just doesn't realise the course has finished.

@Tensuko
Copy link
Contributor

Tensuko commented Jan 2, 2022

So the problem is only he doesn't stop at the stop point ?

@ph1go
Copy link
Author

ph1go commented Jan 2, 2022

So the problem is only he doesn't stop at the stop point ?

Yes, exactly. The field work is perfect, you can see the stop point in the screenshots and that he is past it.

I found another screenshot I took yesterday (but no log) of it also happening with the big Amazone seeder...

fsScreen_2022_01_01_18_40_23

@Tensuko
Copy link
Contributor

Tensuko commented Jan 2, 2022

Can't be the tool. Must be somethiing else what happens there.
Would like to know if that happens without the mods that plays with speeds and stuff.

@Tensuko Tensuko changed the title [BUG_SP] Worker occasionally continues in a straight line for a distance at the end of a course. [BUG_SP] Worker doesn't stop at End of Course. Jan 2, 2022
@ph1go
Copy link
Author

ph1go commented Jan 2, 2022 •
edited
Loading

Hmm, like AutoDrive? I don't know which other ones out of the following could interfere...

FS22_advancedGameplaySettings
FS22_AIVehicleExtension
FS22_AutoDrive
FS22_cultivatorFieldCreator
FS22_EnhancedVehicle
FS22_flieglDPWpack
FS22_Great_KrampePack
FS22_InfoMessageHUD
FS22_real_clock
FS22_TO_sks30_150
FS22_VehicleCameraAutoZoom
FS22_VehicleExplorer

AIVehicleExtension is disabled in all implements (even combines now Courseplay is out), EnhancedVehicle can lock differentials and stuff but nothing to do with speed.

Edit - maybe me changing the speeds in Courseplay might have something to do with it?

@ph1go
Copy link
Author

ph1go commented Jan 2, 2022 •
edited
Loading

Here's a video of it just happening again... You can see him "working" straight past the stop point.

log.txt

@Tensuko
Copy link
Contributor

Tensuko commented Jan 2, 2022

EnhancedVehicle can lock differentials and stuff but nothing to do with speed.

Still can influence the Vehicle behavior.

@Tensuko Tensuko removed the waiting for user User answer needed label Jan 2, 2022
@ph1go
Copy link
Author

ph1go commented Jan 2, 2022 •
edited
Loading

Here's another video, he went much further this time than I've seen before. I'm rolling a field at the moment, I'll reload with that mod disabled and see what happens (although if it doesn't do it, it won't be conclusive because it was already not doing it every time...).

Edit - I disabled AIVE and EnhancedVehicle and... he stopped at the correct place (assuming it's the back of the implement that should be at the stop point). Like I said though I don't think that's conclusive because I've done loads of fieldwork over the last week with all those mods enabled without it happening at all...

fsScreen_2022_01_02_23_55_51

fsScreen_2022_01_02_23_56_18

@Tensuko
Copy link
Contributor

Tensuko commented Jan 3, 2022

But when one of those Mods CAN cause this, we need to know it.
Else we can't do anything and look at our code for hours and can just say, this can't happen...

@pvaiko
Copy link
Contributor

pvaiko commented Jan 3, 2022

That's our bug...

@pvaiko pvaiko closed this as completed in a41327b Jan 3, 2022
@pvaiko
Copy link
Contributor

pvaiko commented Jan 3, 2022

Should work with the latest main branch.

When you load a savegame, check the end of your courses. If the Stop sign is not where it should be (for instance on the neighboring field) you have to regenerate that course.

Tensuko added a commit that referenced this issue Jan 3, 2022
@Tensuko
Push Release 7.0.0.12
bb3d652 
- Implement lowering fix for the Ventor #237
- No plow rotation for headland turns #287
- Added forage Harvester support #332
- Ignore silage additives for now #109
- Course stop fix #323
- Transition from connecting track fix for #335
@Tensuko
Copy link
Contributor

Tensuko commented Jan 3, 2022

Pls try 7.0.0.12
If still have problems, pls reopen and report.

@Tensuko Tensuko reopened this Jan 3, 2022
@Tensuko Tensuko closed this as completed Jan 3, 2022
@ph1go
Copy link
Author

ph1go commented Jan 4, 2022

He fails to reach the end of the course now. :) I scrapped all the old courses so this is a new one, made with v7.0.0.12.

I see 2022-01-04 10:17 :52 [dbg4 lp177570] 9620 RX: WORKING: adding offset (-13.1 front marker) to make sure we do not miss anything when the course ends in the log (line 48755), but...

fsScreen_2022_01_04_10_26_28

log.txt

pvaiko added a commit that referenced this issue Jan 4, 2022
@pvaiko
End of course offset fixed (again) #323
1ea123d 
Copy-paste error fixed
@pvaiko
Copy link
Contributor

pvaiko commented Jan 4, 2022

Oops. Looks like our QA department needs to improve :). This last push should now really solve it...

Tensuko added a commit that referenced this issue Jan 6, 2022
@Tensuko
Push Release 7.0.0.13
831711b 
We removed the H key binding to start Courseplay, H will now start the built-in helper (or bring up the helper screen) as in the vanilla game.
To start the Courseplay helper, there is a new Action (CP Start driver) you can now assign to any key combination in the Keyboard Controls screen, we recommend using Ctrl+H.

- Better corners when scanning fields #337
- End of course offset fixed (again) #323
- Pathfinder debug overlap box disabled
- Work width calculation fix #354
- Moved course display to the background behind the course generator settings fixes #343
- Disabled activating Cp with default keybinding #190
- Added start cp keybinding #190
- Minor fix/refactor for course generator, fixes #352
- Reversing tuning, might help with #378 and closes #353
- Should fix #348 for now
- Added imperial unit foot #128
- fixes #374
- No pathfinder for simple wide turns #340
@Tensuko
Copy link
Contributor

Tensuko commented Jan 6, 2022

Oops. Looks like our QA department needs to improve :). This last push should now really solve it...

Thank you :D

Pls try 7.0.0.13
Reopen if Issue persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pvaiko pvaiko

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pvaiko @Tensuko @ph1go