Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Update vehicles.lua #6943

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Update vehicles.lua #6943

merged 2 commits into from
Mar 4, 2021

Conversation

rgoe
Copy link
Contributor

@rgoe rgoe commented Mar 3, 2021

Regarding #6938 :
Updated code finding the turn radius in AIDriverUtil.getTurningRadius and courseplay.getVehicleTurningRadius to include values from VehicleConfigurations.xml or to revert to a default if no value is found/given (for AIDriverUtil.getTruningRadius).

Updated functions finding the turn radius in AIDriverUtil.getTurningRadius and courseplay.getVehicleTurningRadius to include values from VehicleConfigurations.xml or to revert to a default if no value is found/given.
@Tensuko Tensuko requested a review from pvaiko March 3, 2021 15:22
Copy link
Contributor

@pvaiko pvaiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, we really appreciate this kind of support. It addresses a real issue, just FYI, I believe the root cause is that the pathfinder is calling this function for vehicles it should not, and I'll have to fix that.

vehicles.lua Outdated Show resolved Hide resolved
vehicles.lua Outdated Show resolved Hide resolved
vehicles.lua Outdated Show resolved Hide resolved
vehicles.lua Outdated Show resolved Hide resolved
vehicles.lua Outdated Show resolved Hide resolved
@rgoe rgoe requested a review from pvaiko March 4, 2021 09:17
@rgoe
Copy link
Contributor Author

rgoe commented Mar 4, 2021

Thanks for the in-deep information - I'm really glad if I can be of any help allthough I'm completely new to lua and far from being able to figure out the whole project.

Copy link
Contributor

@pvaiko pvaiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pvaiko pvaiko merged commit af2f28a into Courseplay:master Mar 4, 2021
pvaiko added a commit that referenced this pull request Mar 5, 2021
Debug channel refactoring (#6908)

Channels 1-10 assigned for the corresponding mode 1-10

Hopefully more logical split of other channels.

Possible MP fix for bale loader init

Initialize bale loader only when starting the CP driver,
as that happens only on the server.

On the client where not all data is available keep the
constructor at a minimum.

Disable send event from client on AIDriver init (#6941)

Apparently the noEventSend was not passed all the way down to all the
SiloSelectedFillTypeSetting functions

Turning radius fix (#6943)

Updated functions finding the turn radius in AIDriverUtil.getTurningRadius to include user settings and values from VehicleConfigurations.xml or to revert to a default if no value is found/given.

MP bandaid for #6935

No idea why that error is coming, there were no changes there,
it may be just a buggy mod, in any case try to handle that exception
gracefully.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants