This repository has been archived by the owner on May 23, 2023. It is now read-only.
Debug channel refactoring #6908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Untested but everything should now be refactored
Fixed some missed debugs
One last push
Turn tooltip text fixed
pvaiko
added a commit
that referenced
this pull request
Mar 5, 2021
Debug channel refactoring (#6908) Channels 1-10 assigned for the corresponding mode 1-10 Hopefully more logical split of other channels. Possible MP fix for bale loader init Initialize bale loader only when starting the CP driver, as that happens only on the server. On the client where not all data is available keep the constructor at a minimum. Disable send event from client on AIDriver init (#6941) Apparently the noEventSend was not passed all the way down to all the SiloSelectedFillTypeSetting functions Turning radius fix (#6943) Updated functions finding the turn radius in AIDriverUtil.getTurningRadius to include user settings and values from VehicleConfigurations.xml or to revert to a default if no value is found/given. MP bandaid for #6935 No idea why that error is coming, there were no changes there, it may be just a buggy mod, in any case try to handle that exception gracefully.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reassign debug channels as the current assignment to functions/modes is chaotic and there are a lot of unused channels.
I would like to sort the Channels new.
Like we have a Problem in Mode2: We need Channel 2 (for Mode2) and Pathfinding Debug (e.g. Channel 11).
DBG1 = Mode1
DBG2 = Mode2
DBG3 = Mode3
DBG4 = Mode4
DBG5 = Mode5
DBG6 = Mode6
DBG7 = Mode7
DBG8 = Mode8
DBG9 = Mode9
DBG10 = Mode10
DBG11 = Pathfinder (before: 7)
DBG12 = Trigger (before: 1 or 2 ? not sure about difference)
For Driving Stuff (Old channel 12, 13, 14, and so on) I would split on, maybe like that:
DBG13 = reverse driving
DBG14 = turn
DBG15 = PPC (if it makes sence to have its own dbg channel)
DBG16 = Load/unload
DBG17 = Traffic
DBG20 = Multiplayer
...
Most Important is to have channel 12 splitted, as it prints to many debugs that you don't need sometimes.