Skip to content
This repository has been archived by the owner on Feb 19, 2021. It is now read-only.

Hide application logs in release configuration #561

Merged

Conversation

iseebi
Copy link
Contributor

@iseebi iseebi commented Jun 21, 2020

Purpose

  • Hide application logs in release configuration

リリース構成ではアプリケーションログを出力しないようにすべきです(Androidアプリのセキュア設計・セキュアコーディングガイド 4.8)。

Console.WriteLineを使用した場合、リリース構成でもログが出力されてしまうためDebug.WriteLineに置き換えました。

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

What to Check

Verify that the following are valid

  • ExposureNotificationService と ExposureNotificationHandler の動作に影響がないこと

Other Information

ものによってはRelease構成でも確認したい場合などがあるかもしれないので、その場合はTrace.WriteLineを使い、ストア向け構成の場合はTRACEシンボルも消してビルドすると良いかと思います。

# Conflicts:
#	Covid19Radar/Covid19Radar/Services/ExposureNotificationService.cs
@iseebi iseebi force-pushed the feature/hide_logs_in_release branch from b7e170a to 8eb5e41 Compare June 23, 2020 02:52
@kazumihirose kazumihirose merged commit b406478 into Covid-19Radar:master Jun 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants