This repository has been archived by the owner on Feb 19, 2021. It is now read-only.
Hide application logs in release configuration #561
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
リリース構成ではアプリケーションログを出力しないようにすべきです(Androidアプリのセキュア設計・セキュアコーディングガイド 4.8)。
Console.WriteLineを使用した場合、リリース構成でもログが出力されてしまうためDebug.WriteLineに置き換えました。
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
What to Check
Verify that the following are valid
Other Information
ものによってはRelease構成でも確認したい場合などがあるかもしれないので、その場合はTrace.WriteLineを使い、ストア向け構成の場合はTRACEシンボルも消してビルドすると良いかと思います。