Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Home] Content underneath sheet is available #39

Open
svinkle opened this issue May 25, 2020 · 7 comments
Open

[Home] Content underneath sheet is available #39

svinkle opened this issue May 25, 2020 · 7 comments

Comments

@svinkle
Copy link
Member

svinkle commented May 25, 2020

Issue summary

When the status Sheet is expanded, content underneath the Sheet is still available/focusable via swipe/touch navigation. Mobile screen readers announce this content as if it were a part of the visible Sheet content. This could lead to a confusing user experience.

Screen Shot 2020-05-25 at 2 59 12 PM

Current code

TSX

// BottomSheet.tsx

return (
  <SheetContentsContainer
    isExpanded={isExpanded}
    toggleExpanded={toggleExpanded}
  >
    <>
      {collapsedContentWrapper}
      {expandedContentWrapper}
    </>
  </SheetContentsContainer>
);

Steps to reproduce

  1. Load the app into the iOS simulator
  2. Expand the Sheet content
  3. Enable VoiceOver screen reader on macOS
  4. Use the Virtual Cursor to navigate through the Sheet control

Behavior

Expected

  • Content underneath to not be available via touch/swipe.

Actual

  • Content underneath is available.

Recommendation

A recommendation is not certain at this point. Some experimentation has been conducted on various content containers using the accessibilityViewIsModal prop without success.

Basically, if the isExpanded prop is true, content other than the Sheet should not be available on touch/swipe.

Specifications

  • Component: CovidShield [Home]
  • WCAG Principle: Operable
  • WCAG SC: 2.4.3 Focus Order
  • Severity: Medium
  • Effort: Unknown
@svinkle svinkle changed the title [Sheet] Content underneath sheet is available [Home] Content underneath sheet is available May 26, 2020
henrytao-me pushed a commit that referenced this issue Jun 21, 2020
@AbubakarSambo
Copy link
Contributor

Hi @svinkle , please let me know your thoughts on this: #172

@timarney
Copy link

Believe this is the same issue:
cds-snc/covid-alert-app#292

@AbubakarSambo
Copy link
Contributor

AbubakarSambo commented Jun 30, 2020

yes it is, i believe. I have a somewhat "hacky" solution that hides the background elements when they're not in view and that way the screen reader doesn't read them

@timarney
Copy link

@svinkle it would be great if we can coordinate our efforts on this. I can make someone from my team available but looking to avoid overlap on these fixes. I've been working with @henrytao-me for getting other bug fixes back and forth between the repos.

@AbubakarSambo
Copy link
Contributor

oh, i didn't know someone was working on it already, my bad.

@timarney
Copy link

timarney commented Jun 30, 2020

oh, i didn't know someone was working on it already, my bad.

We're not yet :) just dropped this here to see if anyone else was. Ideally we can coordinate with our repo downstream. Avoiding two solutions to the same issue.

@JuliannaR
Copy link

@henrytao-me henrytao-me self-assigned this Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants