Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Géolocalisation et tri par distance des centres disponibles #38

Merged
merged 21 commits into from
Apr 12, 2021
Merged

Géolocalisation et tri par distance des centres disponibles #38

merged 21 commits into from
Apr 12, 2021

Commits on Apr 11, 2021

  1. Tri selon la distance avec geolocalisation

    @Floby
    Floby committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    0ee0640 View commit details
    Browse the repository at this point in the history

  2. enleve l'auto detection du département

    @Floby
    Floby committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    d5f4d55 View commit details
    Browse the repository at this point in the history

  3. ajoute un message explicatif quand la geoloc est bloquée

    @Floby
    Floby committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    b0a5dcd View commit details
    Browse the repository at this point in the history

  4. remove yarn lock

    @Floby
    Floby committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    c1e97e7 View commit details
    Browse the repository at this point in the history

  5. ajoute le critère de tri à la clé pour déclencher l'animation

    @Floby
    Floby committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    e9300c6 View commit details
    Browse the repository at this point in the history

  6. Update src/components/vmd-appointment-card.component.ts

    @Floby
    Floby committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    b14f601 View commit details
    Browse the repository at this point in the history

  7. fix typo

    @Floby
    Floby committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    f3e0c3e View commit details
    Browse the repository at this point in the history

  8. copie la fonction delay

    @Floby
    Floby committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    71d5efa View commit details
    Browse the repository at this point in the history

  9. enleve bloc en doublon

    @Floby
    Floby committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    a7f0e11 View commit details
    Browse the repository at this point in the history

  10. afficher le message d'erreur geoloc dès la première fois

    @Floby
    Floby committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    6a626e4 View commit details
    Browse the repository at this point in the history

  11. pas d'erreur lorsque la localisation n'est pas présente sur le lieu

    @Floby
    Floby committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    6c7bcf3 View commit details
    Browse the repository at this point in the history

  12. bouge la localisation du navigateur dans le state et distance dans so… 

    …n petit fichier
    @Floby
    Floby committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    5124efa View commit details
    Browse the repository at this point in the history

  13. disable cache parce que ça fait foirer lit-html

    @Floby
    Floby committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    da6252d View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2021

  1. moved vmd-appointment-card animations to vmd-rdv level, as this shoul… 

    …d make animations more flexible
    @fcamblor
    fcamblor committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    0a39180 View commit details
    Browse the repository at this point in the history

  2. using ?attribute instead of .property for checked/disabled attributes… 

    … on radio buttons

and removed preventDefaults on click as it was preventing their default behaviour
    @fcamblor
    fcamblor committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    89aa62f View commit details
    Browse the repository at this point in the history

  3. using cache on State.localisationNavigateur(). Note that if previous … 

    …result was 'indisponible', then we try again as it may have been due to a timeout
    @fcamblor
    fcamblor committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    7b36cfb View commit details
    Browse the repository at this point in the history

  4. showing an error message when location is unavailable

    @fcamblor
    fcamblor committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    9a8f15e View commit details
    Browse the repository at this point in the history

  5. given that afficherTriParDistance's downstream calls after locationNa… 

    …vigateur() are async,

manually triggering a re-rendering once location is resolved as lit-element cannot auto-guess this
    @fcamblor
    fcamblor committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    4a0015c View commit details
    Browse the repository at this point in the history

  6. avoiding calculating displayed (sorted by distance) locations multipl… 

    …e times during render.

solution is to pre-calculate it everytime we fetch locations, or update user's location
    @fcamblor
    fcamblor committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    68e74ee View commit details
    Browse the repository at this point in the history

  7. showing a spinner while resolving user's location (when he clicks on … 

    …distance sorting tab)
    @fcamblor
    fcamblor committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    e9be226 View commit details
    Browse the repository at this point in the history

  8. increased location resolution timeout to 4s, as 2s was generally not … 

    …enough

I had ~50% of timeouts on my laptop with 2s timeout delay. With 4s, it was almost 90%=95%.
    @fcamblor
    fcamblor committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    b8880e1 View commit details
    Browse the repository at this point in the history