New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organize public header files #43

Closed
saschazelzer opened this Issue Sep 24, 2015 · 3 comments

Comments

Projects
None yet
4 participants
@saschazelzer
Member

saschazelzer commented Sep 24, 2015

In anticipation of new modules in the source code, the public header files should be re-organized.

  • Core headers will be located under include/us
  • Other module headers will be located under include/<module>

All header files will be stripped of the "us" prefix and the us namespace will not be optional / changeable any more.

Header files also must not depend on configured information.

@saschazelzer saschazelzer added this to the Release 3.0 milestone Sep 24, 2015

@saschazelzer saschazelzer self-assigned this Sep 24, 2015

@karthikreddy09

This comment has been minimized.

Show comment
Hide comment
@karthikreddy09

karthikreddy09 Nov 18, 2015

Contributor

@jeffdiclemente
I like this idea ... headers in specific folders avoids conflict with similar named headers in global scope.

Would it make sense to use include/CppMicroServices instead of include/us ? I think it helps with readability in client code.

#include "CppMicroServices/Bundle.hpp"
vs
#include "us/Bundle.hpp"

Contributor

karthikreddy09 commented Nov 18, 2015

@jeffdiclemente
I like this idea ... headers in specific folders avoids conflict with similar named headers in global scope.

Would it make sense to use include/CppMicroServices instead of include/us ? I think it helps with readability in client code.

#include "CppMicroServices/Bundle.hpp"
vs
#include "us/Bundle.hpp"

@saschazelzer

This comment has been minimized.

Show comment
Hide comment
@saschazelzer

saschazelzer Nov 23, 2015

Member

You are right, it is definitely more expressive, but also a lot more to type. I would like to get opinions from more people about this.

Member

saschazelzer commented Nov 23, 2015

You are right, it is definitely more expressive, but also a lot more to type. I would like to get opinions from more people about this.

@lygstate

This comment has been minimized.

Show comment
Hide comment
@lygstate

lygstate Jun 24, 2016

I like #include "us/Bundle.hpp"

lygstate commented Jun 24, 2016

I like #include "us/Bundle.hpp"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment