[Declarative Services] duplicate service reference names do not cause an error

[jeffdiclemente]

If a service component has more than one service reference with the same name, no error is produced. This can lead to unexpected behavior which is hard to diagnose at run-time.

The reference name must be unique among all other references in the service component (see RFC).

This type of error should be caught as early as possible. Ideally the SCRCodeGen tool should catch this and return an error which can fail a build.

test case:

{
    "scr" : { "version" : 1,
              "components": [{
                       "implementation-class": "DSSpellCheck::SpellCheckImpl",
                       "references": [{
                         "name": "foo",
                         "interface": "Bar"
                       },
                       {
                         "name": "foo",
                         "interface": "Bar"
                       }]
                       }]
           }
  }