Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LDAPFilter::ToString seg fault #233

Merged
merged 1 commit into from
Aug 24, 2017
Merged

Conversation

jeffdiclemente
Copy link
Member

Fixes #232

Add test cases to increase code coverage.

Signed-off-by: The MathWorks, Inc. Roy.Lurie@mathworks.com

Add test cases to increase code coverage.

Signed-off-by: The MathWorks, Inc. Roy.Lurie@mathworks.com
@jeffdiclemente jeffdiclemente self-assigned this Aug 23, 2017
@codecov-io
Copy link

codecov-io commented Aug 23, 2017

Codecov Report

Merging #233 into development will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #233      +/-   ##
===============================================
+ Coverage        82.82%   82.84%   +0.02%     
===============================================
  Files              186      187       +1     
  Lines            13196    13166      -30     
===============================================
- Hits             10929    10908      -21     
+ Misses            2267     2258       -9
Impacted Files Coverage Δ
framework/src/util/LDAPFilter.cpp 98.36% <100%> (+13.11%) ⬆️
framework/test/gtest/LDAPFilterTest.cpp 100% <100%> (ø)
framework/include/cppmicroservices/Any.h 95.58% <0%> (-1.94%) ⬇️
framework/test/driver/LDAPFilterTest.cpp 82.95% <0%> (-0.05%) ⬇️
framework/include/cppmicroservices/SharedData.h 96.72% <0%> (+1.63%) ⬆️
framework/include/cppmicroservices/AnyMap.h 60% <0%> (+20%) ⬆️

@jeffdiclemente jeffdiclemente requested a review from a team August 23, 2017 14:06
@ksubramz
Copy link
Contributor

ksubramz commented Aug 23, 2017

Jeff, just a comment to tell you that I am working on test cases to improve code coverage of all the LDAP-related files. https://github.com/CppMicroServices/CppMicroServices/tree/codecov-util . There seems to be some overlap between tests, which is fine.

Maybe the main thing to reconcile is my file is named LDAPTest.cpp because it covers all LDAP classes and your file is named LDAPFilterTest.cpp (because it pertains only to LDAPFilter). Maybe this is fine too?

@ksubramz ksubramz merged commit 5c84a22 into development Aug 24, 2017
@jeffdiclemente jeffdiclemente deleted the 232-ldapfilter-segfault branch August 25, 2017 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants