Implement framework properties #51
Conversation
Closes #42 Signed-off-by: The MathWorks, Inc. Roy.Lurie@mathworks.com
There is no longer a need to use the "construct on first use" idiom since global static initialization of the framework has been removed. Signed-off-by: The MathWorks, Inc. Roy.Lurie@mathworks.com
|
+1 nice! I have no remarks related to the actual code changes. However, it looks like some automatic white-space formatting was applied to some files (e.g. Apart from making it harder to review the changes via GitHub (I reviewed them locally with whitespace changes ignored), I suggest to keep the style originally used in the file in question and maybe do a separate cleanup commit later. It is not documented yet, but the default indentation style in use is two spaces, and e.g. no indentation inside After the indentation fix, feel free to merge the PR yourself. |
|
Great! Yes, I will fix up all the indentations first and then merge. Adding information about code style standards (e.g. indentations, etc...) would be very helpful. I wasn't aware that the indentation for the |
No functional changes made. Fixed incorrect indentations made by previous commits. Signed-off-by: The MathWorks, Inc. Roy.Lurie@mathworks.com
Implement framework properties
@saschazelzer, @karthikreddy09
This resolves #42. See #42 for the requirements.