Remove Bundle Threads #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
- Because of the removal of BundleThreads, this test is invalid and will always cause a deadlock (at least on Linux and Mac) Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
achristoforides
requested review from
carneyweb,
kevinleeMW,
jeffdiclemente and
pelliott-mathworks
jeffdiclemente
requested changes
Mar 24, 2021
jeffdiclemente
requested changes
Mar 24, 2021
kevinleeMW
reviewed
Mar 24, 2021
…iles Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
Codecov Report
@@ Coverage Diff @@
## development #533 +/- ##
===============================================
- Coverage 89.77% 89.23% -0.55%
===============================================
Files 237 158 -79
Lines 9706 6616 -3090
===============================================
- Hits 8714 5904 -2810
+ Misses 992 712 -280
|
Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
pelliott-mathworks
approved these changes
Mar 24, 2021
Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
jeffdiclemente
requested changes
Mar 25, 2021
- Changes were requested by reviewer Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
- Changes were requested by reviewer Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
jeffdiclemente
requested changes
Mar 25, 2021
- Removed numberings Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
jeffdiclemente
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the BundleThread functionality from CppMicroServices.
BundleThread.h, BundleThread.cpp, and ConcurrencyTest.cpp are removed from the repo.