Fixes issue where DS/CA do not build if US_BUILD_TESTING isn't ON #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Always cache the value of BUILD_SHARED_LIBS in _us_build_shared rather than only when US_BUILD_TESTING is ON Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
achristoforides
requested review from
carneyweb,
jeffdiclemente and
pelliott-mathworks
jeffdiclemente
approved these changes
Apr 25, 2022
Codecov Report
@@ Coverage Diff @@
## development #661 +/- ##
===============================================
- Coverage 90.48% 90.38% -0.11%
===============================================
Files 249 234 -15
Lines 13467 13223 -244
===============================================
- Hits 12186 11951 -235
+ Misses 1281 1272 -9
|
pelliott-mathworks
approved these changes
Apr 25, 2022
insi-eb
pushed a commit
to insi-eb/CppMicroServices-cpp14
that referenced
this pull request
Oct 5, 2022
…pMicroServices#661) - Always cache the value of BUILD_SHARED_LIBS in _us_build_shared rather than only when US_BUILD_TESTING is ON Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
jeffdiclemente
pushed a commit
that referenced
this pull request
Oct 5, 2022
…) (#735) - Always cache the value of BUILD_SHARED_LIBS in _us_build_shared rather than only when US_BUILD_TESTING is ON Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com> Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com> Co-authored-by: Alexander Christoforides <38366659+achristoforides@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than only when US_BUILD_TESTING is ON
Fixes #660
Signed-off-by: The MathWorks, Inc. alchrist@mathworks.com