Remove manual ref counting for BundleResource #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
achristoforides
requested review from
carneyweb,
jeffdiclemente and
pelliott-mathworks
Codecov Report
@@ Coverage Diff @@
## development #695 +/- ##
===============================================
- Coverage 90.46% 90.36% -0.10%
===============================================
Files 248 233 -15
Lines 13643 13381 -262
===============================================
- Hits 12342 12092 -250
+ Misses 1301 1289 -12
|
Comment on lines
132
to
137
| BundleResource& BundleResource::operator=(const BundleResource& resource) | ||
| { | ||
| BundleResourcePrivate* curr_d = d; | ||
| d = resource.d; | ||
| ++d->ref; | ||
|
|
||
| if (!--curr_d->ref) | ||
| delete curr_d; | ||
|
|
||
| return *this; | ||
| } |
There was a problem hiding this comment.
can the copy assignment operator be =default? I don't think we need a user-defined implementation for this now.
There was a problem hiding this comment.
Yes. That seems like the right change here.
pelliott-mathworks
approved these changes
Jun 27, 2022
Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
jeffdiclemente
approved these changes
Jun 27, 2022
insi-eb
pushed a commit
to insi-eb/CppMicroServices-cpp14
that referenced
this pull request
Jan 31, 2023
* Removed manual ref counting for BundleResource Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com> * Made changes requested by reviewer Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
jeffdiclemente
pushed a commit
that referenced
this pull request
Jan 31, 2023
* Removed manual ref counting for BundleResource * Made changes requested by reviewer Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com> Co-authored-by: Alexander Christoforides <38366659+achristoforides@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: The MathWorks, Inc. alchrist@mathworks.com