Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix when creating instance name for factory components #720

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

pelliott-mathworks
Copy link
Collaborator

The auto generation code uses the component name from the manifest.json file when creating the name of the constructor and destructor for the service instance. The factory component was using the name of the implementation class. This coding change fixes this bug so the name of the component is always used. The name of the component is an optional parameter in the manifest.json file. It defaults to the implementation class when not provided. The implementation class will be used for the instance name in those cases. Signed off by The MathWorks, Inc. pelliott@mathworks.com

The auto generation code uses the component name from the manifest.json file when creating the name of the constructor and destructor for the service instance. The factory component was using the name of the implementation class. This coding change fixes this bug so the name of the component is always used. The name of the component is an optional parameter in the manifest.json file. It defaults to the implementation class when not provided. The implementation class will be used for the instance name in those cases. Signed off by The MathWorks, Inc. <pelliott@mathworks.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2022

Codecov Report

Merging #720 (b8d4ab7) into development (f0a6c6f) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #720      +/-   ##
===============================================
- Coverage        89.78%   89.62%   -0.16%     
===============================================
  Files              231      225       -6     
  Lines            13811    13589     -222     
===============================================
- Hits             12400    12179     -221     
+ Misses            1411     1410       -1     
Impacted Files Coverage Δ
...arativeServices/src/metadata/ComponentMetadata.hpp 100.00% <ø> (ø)
...ervices/src/manager/ComponentConfigurationImpl.cpp 97.87% <100.00%> (-1.15%) ⬇️
...rativeServices/src/metadata/MetadataParserImpl.cpp 90.84% <100.00%> (-0.77%) ⬇️
...ativeServices/src/manager/ReferenceManagerImpl.hpp 94.44% <0.00%> (-5.56%) ⬇️
...anager/BundleOrPrototypeComponentConfiguration.cpp 80.14% <0.00%> (-2.14%) ⬇️
...arativeServices/src/metadata/ReferenceMetadata.cpp 88.57% <0.00%> (-2.13%) ⬇️
framework/src/service/ServiceRegistry.cpp 91.28% <0.00%> (-2.06%) ⬇️
...src/manager/states/CCUnsatisfiedReferenceState.hpp 92.30% <0.00%> (-1.45%) ⬇️
...es/src/manager/SingletonComponentConfiguration.cpp 90.83% <0.00%> (-1.42%) ⬇️
framework/src/service/ServiceReferenceBase.cpp 96.25% <0.00%> (-1.25%) ⬇️
... and 52 more

@pelliott-mathworks pelliott-mathworks merged commit a543239 into development Sep 8, 2022
@pelliott-mathworks pelliott-mathworks deleted the bugfix-factoryname branch September 8, 2022 21:27
insi-eb pushed a commit to insi-eb/CppMicroServices-cpp14 that referenced this pull request Feb 8, 2023
…rvices#720)

The auto generation code uses the component name from the manifest.json file when creating the name of the constructor and destructor for the service instance. The factory component was using the name of the implementation class. This coding change fixes this bug so the name of the component is always used. The name of the component is an optional parameter in the manifest.json file. It defaults to the implementation class when not provided. The implementation class will be used for the instance name in those cases. Signed off by The MathWorks, Inc. <pelliott@mathworks.com>
jeffdiclemente pushed a commit that referenced this pull request Feb 8, 2023
The auto generation code uses the component name from the manifest.json file when creating the name of the constructor and destructor for the service instance. The factory component was using the name of the implementation class. This coding change fixes this bug so the name of the component is always used. The name of the component is an optional parameter in the manifest.json file. It defaults to the implementation class when not provided. The implementation class will be used for the instance name in those cases. Signed off by The MathWorks, Inc. <pelliott@mathworks.com>

Co-authored-by: pelliott-mathworks <67922241+pelliott-mathworks@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants