Fix Flaky test: RequiredActionTotpSetupTest.setupTotpExistingReusable…

…CodeDisabled (keycloak#15779) Closes keycloak#15564
Cracky5457 · Dec 13, 2022 · 5933120 · 5933120
1 parent 453a0cd
commit 5933120
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/.../tests/base/src/test/java/org/keycloak/testsuite/actions/RequiredActionTotpSetupTest.java b/.../tests/base/src/test/java/org/keycloak/testsuite/actions/RequiredActionTotpSetupTest.java
@@ -352,7 +352,9 @@ public void setupTotpExisting(boolean reusableCodesEnabled) {
 
         String totpSecret = totpPage.getTotpSecret();
 
-        totpPage.configure(totp.generateTOTP(totpSecret));
+        String firstCode = totp.generateTOTP(totpSecret);
+
+        totpPage.configure(firstCode);
 
         String authSessionId = events.expectRequiredAction(EventType.UPDATE_TOTP).assertEvent()
                 .getDetails().get(Details.CODE_ID);
@@ -366,17 +368,14 @@ public void setupTotpExisting(boolean reusableCodesEnabled) {
 
         events.expectLogout(authSessionId).assertEvent();
 
-        if (!reusableCodesEnabled) {
-            setTimeOffset(TimeBasedOTP.DEFAULT_INTERVAL_SECONDS);
-        }
-
         loginPage.open();
         loginPage.login("test-user@localhost", "password");
-        String src = driver.getPageSource();
-        loginTotpPage.login(totp.generateTOTP(totpSecret));
+
+        loginTotpPage.login(firstCode);
 
         if (!reusableCodesEnabled) {
             loginTotpPage.assertCurrent();
+            assertEquals("Invalid authenticator code.", loginTotpPage.getInputError());
         } else {
             assertEquals(RequestType.AUTH_RESPONSE, appPage.getRequestType());
             events.expectLogin().assertEvent();