Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rsc create staffing companies #14

Merged
merged 54 commits into from
Nov 6, 2018
Merged

Rsc create staffing companies #14

merged 54 commits into from
Nov 6, 2018

Conversation

RhonGabriel
Copy link
Contributor

@RhonGabriel RhonGabriel commented Nov 4, 2018

PT

https://www.pivotaltracker.com/story/show/161592665

-Added feature test with sad path

  • Added email column for staffing company model
  • Added new, create and show action
  • Create form for adding company information
  • Rendered page using js in order to show forms in modals/pop-up
  • Added validation of email format and uniqueness

screenshot 2018-11-06 at 11 15 31

@coveralls
Copy link

coveralls commented Nov 4, 2018

Pull Request Test Coverage Report for Build 48

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.4%) to 67.619%

Totals Coverage Status
Change from base Build 24: 3.4%
Covered Lines: 71
Relevant Lines: 105

💛 - Coveralls

Copy link
Member

@tochman tochman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look through Zak’s PR with focus on my last commits. I would also advise you to wait until that PR is merged.

Copy link
Member

@tochman tochman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are getting there but I need you to carefully read every line of code that you copy from other parts of the application. The pattern of rendering forms and pages using javascript is a bit complicated and needs your full attention.

app/views/staffcos/_new.html.haml Outdated Show resolved Hide resolved
app/views/staffcos/new.js.erb Show resolved Hide resolved
app/views/staffcos/new.js.erb Show resolved Hide resolved
features/rsc_can_create_new_staffing_companies.feature Outdated Show resolved Hide resolved
features/rsc_can_create_new_staffing_companies.feature Outdated Show resolved Hide resolved
app/controllers/staffcos_controller.rb Outdated Show resolved Hide resolved
app/views/staffcos/_index.html.haml Outdated Show resolved Hide resolved
@RhonGabriel RhonGabriel changed the title [WIP] Rsc create staffing companies Rsc create staffing companies Nov 6, 2018
app/controllers/staffcos_controller.rb Outdated Show resolved Hide resolved
@Prozak8 Prozak8 self-requested a review November 6, 2018 15:47
@Noelryn Noelryn merged commit 9108e82 into CraftAcademy:development Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants