Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User profile #12

Merged
merged 9 commits into from
Sep 9, 2019
Merged

User profile #12

merged 9 commits into from
Sep 9, 2019

Conversation

pedbr
Copy link
Contributor

@pedbr pedbr commented Sep 9, 2019

User Story

As a registered user
In order to manage my account,
I would like to have a profile page

Feature description

https://www.pivotaltracker.com/story/show/168252138

Description of PR

  • Create Profile Component
  • Add React Router and paths to switch between home and profile components
  • Create logic so that only logged in users can see profile button

tochman
tochman approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@tochman tochman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I would add more information on the profile page, but I guess you have a consequent story for that. Merging.

@tochman tochman merged commit 1cf14b4 into CraftAcademy:development Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tochman tochman tochman approved these changes

@erikwesterberg erikwesterberg erikwesterberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pedbr @tochman @erikwesterberg